Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: test/win/win_multiprocess.cc

Issue 1160843006: win: add a child ProcessReader test (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: . Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « snapshot/win/process_reader_win_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/win/win_multiprocess.cc
diff --git a/test/win/win_multiprocess.cc b/test/win/win_multiprocess.cc
index 9955e33d73c067c0cf45af8744e8c2e4f8126032..1eece13f1cd825bf59907dd1001368956ec93242 100644
--- a/test/win/win_multiprocess.cc
+++ b/test/win/win_multiprocess.cc
@@ -168,6 +168,11 @@ void WinMultiprocess::Run() {
WinMultiprocessParent();
+ // Close our side of the handles now that we're done. The child can
+ // use this to know when it's safe to complete.
+ pipe_p2c_write_.reset();
+ pipe_c2p_read_.reset();
+
// Wait for the child to complete.
ASSERT_EQ(WAIT_OBJECT_0,
WaitForSingleObject(child_handle_.get(), INFINITE));
« no previous file with comments | « snapshot/win/process_reader_win_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698