Issue 1160843006: win: add a child ProcessReader test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1160843006: win: add a child ProcessReader test (Closed)

Created:
5 years, 6 months ago by scottmg

Modified:
5 years, 6 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

win: add a child ProcessReader test Now that we have a multiprocess test harness, add a test for ProcessReaderWin for reading from a child. Parent test code wasn't closing handles properly; fix that. R=rsesek@chromium.org BUG=crashpad:1 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/ac709baa2ea6627bf72d280bd3d00c41b09f0517

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -0 lines)			Patch
	M	snapshot/win/process_reader_win_test.cc	View	1 2	2 chunks	+46 lines, -0 lines	0 comments	Download
	M	test/win/win_multiprocess.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

scottmg

5 years, 6 months ago (2015-06-01 17:07:57 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:60001) manually as
ac709baa2ea6627bf72d280bd3d00c41b09f0517 (presubmit successful).