Issue 1160843005: Add hello_fn2.dart and make Text("Hello fn2") actually render something.

Issue 1160843005: Add hello_fn2.dart and make Text("Hello fn2") actually render something. (Closed)

Created:
5 years, 6 months ago by eseidel

Modified:
5 years, 6 months ago

Reviewers:
Hixie, abarth-chromium

CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add hello_fn2.dart and make Text("Hello fn2") actually render something. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/1f65ac3696f941f0796310ad8da566834285b594

Patch Set 3 : Fixored #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -37 lines)			Patch
A +	sky/examples/fn2/hello_fn2.dart	View	1 2	1 chunk	+6 lines, -2 lines	0 comments	Download
M	sky/sdk/lib/framework/fn2.dart	View	1 2	4 chunks	+12 lines, -30 lines	0 comments	Download
M	sky/sdk/lib/framework/layout2.dart	View		2 chunks	+14 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

abarth-chromium

Maybe move fn2_hello to sky/examples/fn2 https://codereview.chromium.org/1160843005/diff/20001/sky/sdk/lib/framework/fn2.dart File sky/sdk/lib/framework/fn2.dart (right): https://codereview.chromium.org/1160843005/diff/20001/sky/sdk/lib/framework/fn2.dart#newcode921 sky/sdk/lib/framework/fn2.dart:921: UINode build() => new ...

5 years, 6 months ago (2015-05-28 20:53:00 UTC) #3

eseidel

5 years, 6 months ago (2015-05-28 20:56:41 UTC) #7

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
1f65ac3696f941f0796310ad8da566834285b594 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages