Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1160833005: roll_dep.py: switch to argparse (Closed)

Created:
5 years, 6 months ago by Sam Clegg
Modified:
5 years, 6 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

roll_dep.py: switch to argparse This makes for cleaner code and better --help. Also, handle case when deps directory does not exist. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295475

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -16 lines) Patch
M roll_dep.py View 1 4 chunks +17 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Sam Clegg
5 years, 6 months ago (2015-05-29 22:15:50 UTC) #2
M-A Ruel
lgtm either way https://codereview.chromium.org/1160833005/diff/1/roll_dep.py File roll_dep.py (right): https://codereview.chromium.org/1160833005/diff/1/roll_dep.py#newcode140 roll_dep.py:140: if args.reviewer is not None: Actually ...
5 years, 6 months ago (2015-05-29 22:57:37 UTC) #3
Sam Clegg
On 2015/05/29 22:57:37, M-A Ruel wrote: > lgtm either way > > https://codereview.chromium.org/1160833005/diff/1/roll_dep.py > File ...
5 years, 6 months ago (2015-06-01 17:52:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160833005/20001
5 years, 6 months ago (2015-06-01 18:04:07 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 18:07:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295475

Powered by Google App Engine
This is Rietveld 408576698