Add support for null-aware operators to the CPS-IR.

tests/language/language_dart2js.status

Index: tests/language/language_dart2js.status
diff --git a/tests/language/language_dart2js.status b/tests/language/language_dart2js.status
index ea9c7262ff2fad3717a104bd0cd020a83e60a85b..12da7080325367eccd158daa1cf365c5e3e99981 100644
--- a/tests/language/language_dart2js.status
+++ b/tests/language/language_dart2js.status
@@ -423,45 +423,14 @@ closures_initializer2_test: Crash # Please triage this failure.
 closures_initializer_test: Crash # Instance of 'TypeOperator': type check unimplemented for List<int>.
 compile_time_constant_a_test: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.
 compile_time_constant_b_test: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.
-conditional_method_invocation_test/01: RuntimeError # Please triage this failure.
-conditional_method_invocation_test/02: RuntimeError # Please triage this failure.
-conditional_method_invocation_test/03: RuntimeError # Please triage this failure.
-conditional_method_invocation_test/04: RuntimeError # Please triage this failure.
-conditional_method_invocation_test/05: RuntimeError # Please triage this failure.
-conditional_method_invocation_test/06: RuntimeError # Please triage this failure.
-conditional_method_invocation_test/07: RuntimeError # Please triage this failure.
-conditional_method_invocation_test/08: RuntimeError # Please triage this failure.
 conditional_method_invocation_test/09: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.
 conditional_method_invocation_test/10: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.
 conditional_method_invocation_test/11: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.
-conditional_method_invocation_test/12: RuntimeError # Please triage this failure.
-conditional_method_invocation_test/13: RuntimeError # Please triage this failure.
-conditional_method_invocation_test/none: RuntimeError # Please triage this failure.
-conditional_property_access_test/01: RuntimeError # Please triage this failure.
-conditional_property_access_test/02: RuntimeError # Please triage this failure.
-conditional_property_access_test/03: RuntimeError # Please triage this failure.
-conditional_property_access_test/04: RuntimeError # Please triage this failure.
-conditional_property_access_test/05: RuntimeError # Please triage this failure.
-conditional_property_access_test/06: RuntimeError # Please triage this failure.
 conditional_property_access_test/07: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.
 conditional_property_access_test/08: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.
 conditional_property_access_test/09: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.
-conditional_property_access_test/10: RuntimeError # Please triage this failure.
-conditional_property_access_test/11: RuntimeError # Please triage this failure.
-conditional_property_access_test/none: RuntimeError # Please triage this failure.
-conditional_property_assignment_test/01: RuntimeError # Please triage this failure.
-conditional_property_assignment_test/02: RuntimeError # Please triage this failure.
-conditional_property_assignment_test/03: RuntimeError # Please triage this failure.
-conditional_property_assignment_test/04: RuntimeError # Please triage this failure.
-conditional_property_assignment_test/05: RuntimeError # Please triage this failure.
 conditional_property_assignment_test/06: Crash # Instance of 'TypeOperator': type casts not implemented.
-conditional_property_assignment_test/07: RuntimeError # Please triage this failure.
-conditional_property_assignment_test/08: RuntimeError # Please triage this failure.
-conditional_property_assignment_test/09: RuntimeError # Please triage this failure.
-conditional_property_assignment_test/10: RuntimeError # Please triage this failure.
 conditional_property_assignment_test/11: Crash # Instance of 'TypeOperator': type casts not implemented.
-conditional_property_assignment_test/12: RuntimeError # Please triage this failure.
-conditional_property_assignment_test/13: RuntimeError # Please triage this failure.
 conditional_property_assignment_test/14: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.
 conditional_property_assignment_test/15: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.
 conditional_property_assignment_test/16: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.
@@ -471,7 +440,6 @@ conditional_property_assignment_test/19: Crash # Instance of 'TypeOperator': typ
 conditional_property_assignment_test/20: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.
 conditional_property_assignment_test/21: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.
 conditional_property_assignment_test/22: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.
-conditional_property_assignment_test/none: RuntimeError # Please triage this failure.
 const_evaluation_test/01: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.
 const_nested_test: Crash # Please triage this failure.
 const_objects_are_immutable_test/01: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.
@@ -706,105 +674,51 @@ generic_native_test: Crash # Instance of 'TypeOperator': type check unimplemente
 generic_object_type_test: Crash # Instance of 'TypeOperator': type check unimplemented for T.
 generic_parameterized_extends_test: Crash # Instance of 'TypeOperator': type check unimplemented for A<Object>.
 generic_test: Crash # Instance of 'TypeOperator': type check unimplemented for B<AA>.
-if_null_assignment_behavior_test/01: Crash # Please triage this failure.
-if_null_assignment_behavior_test/02: Crash # Please triage this failure.
-if_null_assignment_behavior_test/03: Crash # Please triage this failure.
-if_null_assignment_behavior_test/04: Crash # Please triage this failure.
-if_null_assignment_behavior_test/05: Crash # Please triage this failure.
-if_null_assignment_behavior_test/06: Crash # Please triage this failure.
-if_null_assignment_behavior_test/07: Crash # Please triage this failure.
-if_null_assignment_behavior_test/08: Crash # Please triage this failure.
-if_null_assignment_behavior_test/09: Crash # Please triage this failure.
-if_null_assignment_behavior_test/10: Crash # Please triage this failure.
-if_null_assignment_behavior_test/11: Crash # Please triage this failure.
-if_null_assignment_behavior_test/12: Crash # Please triage this failure.
-if_null_assignment_behavior_test/15: Crash # Please triage this failure.
-if_null_assignment_behavior_test/16: Crash # Please triage this failure.
-if_null_assignment_behavior_test/17: Crash # Please triage this failure.
-if_null_assignment_behavior_test/18: Crash # Please triage this failure.
-if_null_assignment_behavior_test/19: Crash # Please triage this failure.
-if_null_assignment_behavior_test/20: Crash # Please triage this failure.
-if_null_assignment_behavior_test/21: Crash # Please triage this failure.
-if_null_assignment_behavior_test/22: Crash # Please triage this failure.
-if_null_assignment_behavior_test/23: Crash # Please triage this failure.
-if_null_assignment_behavior_test/24: Crash # Please triage this failure.
-if_null_assignment_behavior_test/25: Crash # Please triage this failure.
-if_null_assignment_behavior_test/26: Crash # Please triage this failure.
-if_null_assignment_behavior_test/27: Crash # Please triage this failure.
-if_null_assignment_behavior_test/28: Crash # Please triage this failure.
-if_null_assignment_behavior_test/none: Crash # Please triage this failure.
-if_null_assignment_static_test/01: Crash # Please triage this failure.
-if_null_assignment_static_test/02: Crash # Please triage this failure.
-if_null_assignment_static_test/03: Crash # Please triage this failure.
-if_null_assignment_static_test/04: Crash # Please triage this failure.
-if_null_assignment_static_test/05: Crash # Please triage this failure.
-if_null_assignment_static_test/06: Crash # Please triage this failure.
-if_null_assignment_static_test/07: Crash # Please triage this failure.
-if_null_assignment_static_test/08: Crash # Please triage this failure.
-if_null_assignment_static_test/09: Crash # Please triage this failure.
-if_null_assignment_static_test/10: Crash # Please triage this failure.
-if_null_assignment_static_test/11: Crash # Please triage this failure.
-if_null_assignment_static_test/12: Crash # Please triage this failure.
-if_null_assignment_static_test/13: Crash # Please triage this failure.
-if_null_assignment_static_test/14: Crash # Please triage this failure.
-if_null_assignment_static_test/15: Crash # Please triage this failure.
-if_null_assignment_static_test/16: Crash # Please triage this failure.
-if_null_assignment_static_test/17: Crash # Please triage this failure.
-if_null_assignment_static_test/18: Crash # Please triage this failure.
-if_null_assignment_static_test/19: Crash # Please triage this failure.
-if_null_assignment_static_test/20: Crash # Please triage this failure.
-if_null_assignment_static_test/21: Crash # Please triage this failure.
-if_null_assignment_static_test/22: Crash # Please triage this failure.
-if_null_assignment_static_test/23: Crash # Please triage this failure.
-if_null_assignment_static_test/24: Crash # Please triage this failure.
-if_null_assignment_static_test/25: Crash # Please triage this failure.
-if_null_assignment_static_test/26: Crash # Please triage this failure.
-if_null_assignment_static_test/27: Crash # Please triage this failure.
-if_null_assignment_static_test/28: Crash # Please triage this failure.
-if_null_assignment_static_test/29: Crash # Please triage this failure.
-if_null_assignment_static_test/30: Crash # Please triage this failure.
-if_null_assignment_static_test/31: Crash # Please triage this failure.
-if_null_assignment_static_test/32: Crash # Please triage this failure.
-if_null_assignment_static_test/33: Crash # Please triage this failure.
-if_null_assignment_static_test/34: Crash # Please triage this failure.
-if_null_assignment_static_test/35: Crash # Please triage this failure.
-if_null_assignment_static_test/36: Crash # Please triage this failure.
-if_null_assignment_static_test/37: Crash # Please triage this failure.
-if_null_assignment_static_test/38: Crash # Please triage this failure.
-if_null_assignment_static_test/39: Crash # Please triage this failure.
-if_null_assignment_static_test/40: Crash # Please triage this failure.
-if_null_assignment_static_test/41: Crash # Please triage this failure.
-if_null_assignment_static_test/42: Crash # Please triage this failure.
-if_null_assignment_static_test/none: Crash # Please triage this failure.
-if_null_behavior_test/01: Crash # (null??null): If-null not yet implemented in cps_ir
-if_null_behavior_test/02: Crash # (null??null): If-null not yet implemented in cps_ir
-if_null_behavior_test/03: Crash # (null??null): If-null not yet implemented in cps_ir
-if_null_behavior_test/04: Crash # (null??null): If-null not yet implemented in cps_ir
-if_null_behavior_test/05: Crash # (null??null): If-null not yet implemented in cps_ir
-if_null_behavior_test/06: Crash # (null??null): If-null not yet implemented in cps_ir
-if_null_behavior_test/07: Crash # (null??null): If-null not yet implemented in cps_ir
-if_null_behavior_test/08: Crash # (null??null): If-null not yet implemented in cps_ir
-if_null_behavior_test/09: Crash # (null??null): If-null not yet implemented in cps_ir
-if_null_behavior_test/10: Crash # (null??null): If-null not yet implemented in cps_ir
-if_null_behavior_test/11: Crash # (null??null): If-null not yet implemented in cps_ir
-if_null_behavior_test/12: Crash # (null??null): If-null not yet implemented in cps_ir
-if_null_behavior_test/13: Crash # (null??null): If-null not yet implemented in cps_ir
-if_null_behavior_test/14: Crash # (null??null): If-null not yet implemented in cps_ir
-if_null_behavior_test/15: Crash # (null??null): If-null not yet implemented in cps_ir
-if_null_behavior_test/16: Crash # (null??null): If-null not yet implemented in cps_ir
-if_null_behavior_test/none: Crash # (null??null): If-null not yet implemented in cps_ir
-if_null_evaluation_order_test/01: Crash # (null??null): If-null not yet implemented in cps_ir
-if_null_evaluation_order_test/02: Crash # (null??null): If-null not yet implemented in cps_ir
-if_null_evaluation_order_test/none: Crash # (null??null): If-null not yet implemented in cps_ir
-if_null_precedence_test/01: Crash # (null??null): If-null not yet implemented in cps_ir
-if_null_precedence_test/02: Crash # (null??null): If-null not yet implemented in cps_ir
-if_null_precedence_test/03: Crash # (null??null): If-null not yet implemented in cps_ir
-if_null_precedence_test/04: Crash # (null??null): If-null not yet implemented in cps_ir
-if_null_precedence_test/05: Crash # (null??null): If-null not yet implemented in cps_ir
-if_null_precedence_test/06: Crash # (null??null): If-null not yet implemented in cps_ir
-if_null_precedence_test/07: Crash # (null??null): If-null not yet implemented in cps_ir
-if_null_precedence_test/08: Crash # (null??null): If-null not yet implemented in cps_ir
-if_null_precedence_test/none: Crash # (null??null): If-null not yet implemented in cps_ir
+if_null_assignment_behavior_test/04: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.

[Siggi Cherem (dart-lang), 2015/05/28 02:15:34]

There are still some tests failures, which boil down to 3 issues:

- is-checks of function typedefs are not implemented.

Turns out this is not really used by the tests. It is used in Expect.throws to
provide an error message if the callback it receives has a wrong number of
arguments. If I remove that check in expect.dart, all tests crashing with this
end up passing.

- type casts are not implemented (used in 2 tests).

- A.a/B.b are tree-shaken: not sure what's going on here. This program works:
     class A { get a => print('foo'); }
     main() {
       var x = null;
       new A().a;         // **
       (x ??= new A()).a;
     }

  but if I remove the marked line (**), the getter `a` is not generated.

  Any clues on what could be happening?

+if_null_assignment_static_test/01: RuntimeError # A.a incorrectly tree-shaken
+if_null_assignment_static_test/02: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.
+if_null_assignment_static_test/03: RuntimeError # A.a incorrectly tree-shaken
+if_null_assignment_static_test/04: RuntimeError # B.b incorrectly tree-shaken
+if_null_assignment_static_test/05: RuntimeError # A.a incorrectly tree-shaken
+if_null_assignment_static_test/06: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.
+if_null_assignment_static_test/08: RuntimeError # A.a incorrectly tree-shaken
+if_null_assignment_static_test/09: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.
+if_null_assignment_static_test/10: RuntimeError # A.a incorrectly tree-shaken
+if_null_assignment_static_test/11: RuntimeError # B.b incorrectly tree-shaken
+if_null_assignment_static_test/12: RuntimeError # A.a incorrectly tree-shaken
+if_null_assignment_static_test/13: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.
+if_null_assignment_static_test/15: RuntimeError # A.a incorrectly tree-shaken
+if_null_assignment_static_test/16: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.
+if_null_assignment_static_test/17: RuntimeError # A.a incorrectly tree-shaken
+if_null_assignment_static_test/18: RuntimeError # B.b incorrectly tree-shaken
+if_null_assignment_static_test/19: RuntimeError # A.a incorrectly tree-shaken
+if_null_assignment_static_test/20: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.
+if_null_assignment_static_test/22: RuntimeError # A.a incorrectly tree-shaken
+if_null_assignment_static_test/23: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.
+if_null_assignment_static_test/24: RuntimeError # A.a incorrectly tree-shaken
+if_null_assignment_static_test/25: RuntimeError # B.b incorrectly tree-shaken
+if_null_assignment_static_test/26: RuntimeError # A.a incorrectly tree-shaken
+if_null_assignment_static_test/27: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.
+if_null_assignment_static_test/29: RuntimeError # A.a incorrectly tree-shaken
+if_null_assignment_static_test/30: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.
+if_null_assignment_static_test/31: RuntimeError # A.a incorrectly tree-shaken
+if_null_assignment_static_test/32: RuntimeError # B.b incorrectly tree-shaken
+if_null_assignment_static_test/33: RuntimeError # A.a incorrectly tree-shaken
+if_null_assignment_static_test/34: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.
+if_null_assignment_static_test/36: RuntimeError # A.a incorrectly tree-shaken
+if_null_assignment_static_test/37: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.
+if_null_assignment_static_test/38: RuntimeError # A.a incorrectly tree-shaken
+if_null_assignment_static_test/39: RuntimeError # B.b incorrectly tree-shaken
+if_null_assignment_static_test/40: RuntimeError # A.a incorrectly tree-shaken
+if_null_assignment_static_test/41: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.
+if_null_behavior_test/07: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.
+if_null_behavior_test/10: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.
+if_null_behavior_test/12: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.
+if_null_behavior_test/14: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.
+if_null_behavior_test/15: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.
+if_null_behavior_test/16: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.
+if_null_precedence_test/07: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.
+if_null_precedence_test/08: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.
 implicit_super_constructor_call_test: Crash # Please triage this failure.
 import_self_test/01: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.
 inference_captured_variable2_test: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary.