Issue 116083008: Document fullscreen/ESC behaviour.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 116083008: Document fullscreen/ESC behaviour. (Closed)

Created:
6 years, 11 months ago by mlamouri (slow - plz ping)

Modified:
6 years, 11 months ago

Reviewers:
benwells

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Document fullscreen/ESC behaviour. And the fact that the user can leave fullscreen by pressing ESC but this can be prevented by the developer by cancelling the event and requesting a special permission. BUG=320487 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243087

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	chrome/common/extensions/api/app_window.idl	View	1	1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

benwells

lgtm https://codereview.chromium.org/116083008/diff/1/chrome/common/extensions/api/app_window.idl File chrome/common/extensions/api/app_window.idl (right): https://codereview.chromium.org/116083008/diff/1/chrome/common/extensions/api/app_window.idl#newcode144 chrome/common/extensions/api/app_window.idl:144: // function(e) { if (e.keyCode == 27 /* ...

6 years, 11 months ago (2014-01-06 05:28:24 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/116083008/60001

6 years, 11 months ago (2014-01-06 10:10:53 UTC) #3

Message was sent while issue was closed.

Change committed as 243087

Expand Messages | Collapse Messages