Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1160823007: HttpServerProperties - Don't persist if SetSupportsQuic is called with (Closed)

Created:
5 years, 6 months ago by ramant (doing other things)
Modified:
5 years, 6 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

HttpServerProperties - Don't persist if SetSupportsQuic is called with the same data more than once. BUG=451256 R=rch@chromium.org Committed: https://crrev.com/fc60cda130136ffffcc6be4fb4bd7d9552ff42fb Cr-Commit-Position: refs/heads/master@{#333651}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M net/http/http_server_properties_manager.cc View 1 chunk +6 lines, -1 line 0 comments Download
M net/http/http_server_properties_manager_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ramant (doing other things)
5 years, 6 months ago (2015-06-08 18:04:04 UTC) #1
Ryan Hamilton
lgtm
5 years, 6 months ago (2015-06-09 22:10:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160823007/1
5 years, 6 months ago (2015-06-09 22:59:24 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-10 02:09:03 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 02:10:00 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc60cda130136ffffcc6be4fb4bd7d9552ff42fb
Cr-Commit-Position: refs/heads/master@{#333651}

Powered by Google App Engine
This is Rietveld 408576698