Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1160813009: Enum DictionaryEntryType removed. (Closed)

Created:
5 years, 6 months ago by Igor Sheludko
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Enum DictionaryEntryType removed. Dictionary customization should be implemented in respective shape class. Committed: https://crrev.com/aa470e0af0e5aca930ddc38ed8cbe098440e07cc Cr-Commit-Position: refs/heads/master@{#28738}

Patch Set 1 : #

Patch Set 2 : Rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -129 lines) Patch
M src/objects.h View 1 6 chunks +21 lines, -63 lines 0 comments Download
M src/objects.cc View 1 16 chunks +36 lines, -64 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/runtime/runtime-array.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Igor Sheludko
PTAL, step 3
5 years, 6 months ago (2015-05-29 19:56:23 UTC) #3
Igor Sheludko
PTAL, step 3
5 years, 6 months ago (2015-06-01 14:08:13 UTC) #5
Jakob Kummerow
lgtm
5 years, 6 months ago (2015-06-01 15:14:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160813009/40001
5 years, 6 months ago (2015-06-01 16:32:13 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 6 months ago (2015-06-01 17:07:32 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 17:07:51 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aa470e0af0e5aca930ddc38ed8cbe098440e07cc
Cr-Commit-Position: refs/heads/master@{#28738}

Powered by Google App Engine
This is Rietveld 408576698