Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 11608: * Added tests for regexp-macro-assembler-ia32. (Closed)

Created:
12 years ago by Lasse Reichstein
Modified:
9 years, 6 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Tests for RegExpMacroAssemblerIA32. Disabled stack-limit checks.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+350 lines, -73 lines) Patch
M src/assembler-ia32.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M src/regexp-macro-assembler-ia32.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/regexp-macro-assembler-ia32.cc View 15 chunks +98 lines, -67 lines 8 comments Download
M test/cctest/cctest.h View 1 chunk +8 lines, -0 lines 0 comments Download
M test/cctest/test-regexp.cc View 1 chunk +233 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein
Smallish review. New tests, and fix of some bugs found by these tests.
12 years ago (2008-11-25 12:02:34 UTC) #1
Erik Corry
LGTM http://codereview.chromium.org/11608/diff/1/3 File src/regexp-macro-assembler-ia32.cc (right): http://codereview.chromium.org/11608/diff/1/3#newcode41 Line 41: * NOTICE: This is the byte offset, ...
12 years ago (2008-11-25 12:39:11 UTC) #2
Lasse Reichstein
12 years ago (2008-11-25 13:05:47 UTC) #3
http://codereview.chromium.org/11608/diff/1/3
File src/regexp-macro-assembler-ia32.cc (right):

http://codereview.chromium.org/11608/diff/1/3#newcode81
Line 81: bool ignore_case)
I see that the CheckNotBackReferenceCaseIndependent method has been added. In
that case there indeed isn't any need for this parameter any more.

http://codereview.chromium.org/11608/diff/1/3#newcode499
Line 499: ASSERT(register_index >= num_saved_registers_);  // Reserved for
positions!
It won't work for positions, as currently implemented. Internally, a position is
stored as a negative byte index from the end of the string. You should only ever
use WriteCurrentPositionToRegister to create position values.
If we need to store a position, we should create
 WritePositionToRegister(int reg, int cp_offset)

Powered by Google App Engine
This is Rietveld 408576698