Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(43)

Issue 1160793007: Include aria-label in acc name calculation. (Closed)

Created:
4 years, 11 months ago by aboxhall
Modified:
4 years, 10 months ago
Reviewers:
dmazzoni
CC:
blink-reviews, je_julie, nektarios, dmazzoni, aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Include aria-label in acc name calculation. BUG=473220 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196687

Patch Set 1 #

Total comments: 4

Patch Set 2 : dmazzoni review comments #

Patch Set 3 : Missing y #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -0 lines) Patch
A LayoutTests/accessibility/name-calc-aria-label.html View 1 2 1 chunk +111 lines, -0 lines 0 comments Download
M Source/modules/accessibility/AXNodeObject.cpp View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
aboxhall
4 years, 11 months ago (2015-06-05 03:48:50 UTC) #2
dmazzoni
lgtm Great tests, thanks! https://codereview.chromium.org/1160793007/diff/1/LayoutTests/accessibility/name-calc-aria-label.html File LayoutTests/accessibility/name-calc-aria-label.html (right): https://codereview.chromium.org/1160793007/diff/1/LayoutTests/accessibility/name-calc-aria-label.html#newcode16 LayoutTests/accessibility/name-calc-aria-label.html:16: test(function(t){ Nit: space between ")" ...
4 years, 11 months ago (2015-06-05 19:46:02 UTC) #3
aboxhall
https://codereview.chromium.org/1160793007/diff/1/LayoutTests/accessibility/name-calc-aria-label.html File LayoutTests/accessibility/name-calc-aria-label.html (right): https://codereview.chromium.org/1160793007/diff/1/LayoutTests/accessibility/name-calc-aria-label.html#newcode16 LayoutTests/accessibility/name-calc-aria-label.html:16: test(function(t){ On 2015/06/05 19:46:01, dmazzoni wrote: > Nit: space ...
4 years, 11 months ago (2015-06-05 19:53:57 UTC) #4
aboxhall
4 years, 11 months ago (2015-06-05 19:54:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160793007/40001
4 years, 11 months ago (2015-06-05 19:55:31 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/65514)
4 years, 11 months ago (2015-06-05 22:40:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160793007/40001
4 years, 10 months ago (2015-06-08 16:16:55 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2015-06-08 17:37:00 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196687

Powered by Google App Engine
This is Rietveld 408576698