Include aria-label in acc name calculation.

Include aria-label in acc name calculation.

BUG=473220
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196687

[aboxhall, 2015-06-05 03:48:49]

aboxhall@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2015-06-05 19:46:02]

lgtm

Great tests, thanks!

https://codereview.chromium.org/1160793007/diff/1/LayoutTests/accessibility/n...
File LayoutTests/accessibility/name-calc-aria-label.html (right):

https://codereview.chromium.org/1160793007/diff/1/LayoutTests/accessibility/n...
LayoutTests/accessibility/name-calc-aria-label.html:16: test(function(t){
Nit: space between ")" and "{" (and more below)

https://codereview.chromium.org/1160793007/diff/1/LayoutTests/accessibility/n...
LayoutTests/accessibility/name-calc-aria-label.html:105: }, "Button with chain
of aria-labelledby references.");
Could you maybe make it clear that the aria-labelledby is not supposed to be
followed recursively, like "Button gets aria-label from aria-labelledby
reference but doesn't follow aria-labelledby of reference recursively" or
something like that but better? :) Or keep the test title the same but add a
comment to the test so that it's clear that this is intentional.

[aboxhall, 2015-06-05 19:53:57]

https://codereview.chromium.org/1160793007/diff/1/LayoutTests/accessibility/n...
File LayoutTests/accessibility/name-calc-aria-label.html (right):

https://codereview.chromium.org/1160793007/diff/1/LayoutTests/accessibility/n...
LayoutTests/accessibility/name-calc-aria-label.html:16: test(function(t){
On 2015/06/05 19:46:01, dmazzoni wrote:
> Nit: space between ")" and "{" (and more below)

Done.

https://codereview.chromium.org/1160793007/diff/1/LayoutTests/accessibility/n...
LayoutTests/accessibility/name-calc-aria-label.html:105: }, "Button with chain
of aria-labelledby references.");
On 2015/06/05 19:46:01, dmazzoni wrote:
> Could you maybe make it clear that the aria-labelledby is not supposed to be
> followed recursively, like "Button gets aria-label from aria-labelledby
> reference but doesn't follow aria-labelledby of reference recursively" or
> something like that but better? :) Or keep the test title the same but add a
> comment to the test so that it's clear that this is intentional.
> 

Fixed up the test title, thanks.

[aboxhall, 2015-06-05 19:55:01]

The CQ bit was checked by aboxhall@chromium.org

[aboxhall, 2015-06-05 19:55:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/1160793007/#ps40001
(title: "Missing y")

[commit-bot: I haz the power, 2015-06-05 19:55:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1160793007/40001

[commit-bot: I haz the power, 2015-06-05 22:40:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-05 22:40:42]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/65514)

[aboxhall, 2015-06-08 16:16:26]

The CQ bit was checked by aboxhall@chromium.org

[commit-bot: I haz the power, 2015-06-08 16:16:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1160793007/40001

[commit-bot: I haz the power, 2015-06-08 17:37:00]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196687