Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Issue 1160793005: Allow trace-viewer to use exec_script in GN. (Closed)

Created:
5 years, 6 months ago by dsinclair
Modified:
5 years, 6 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow trace-viewer to use exec_script in GN. Trace-viewer currently maintains two copies of its input files. This causes duplicate work each time we add a file. I'd like to share a single .gypi file between GYP and GN but need to use exec_script in order to do so. This CL adds an exeception to allow trace-viewer to use exec_script in its BUILD.gn file. Committed: https://crrev.com/f4e1a7ade87e16677474ff662bffb03ae0ae0047 Cr-Commit-Position: refs/heads/master@{#332892}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M .gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dsinclair
PTAL.
5 years, 6 months ago (2015-06-04 14:39:24 UTC) #2
brettw
lgtm
5 years, 6 months ago (2015-06-04 19:18:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160793005/1
5 years, 6 months ago (2015-06-04 19:30:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-04 20:05:55 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 20:06:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f4e1a7ade87e16677474ff662bffb03ae0ae0047
Cr-Commit-Position: refs/heads/master@{#332892}

Powered by Google App Engine
This is Rietveld 408576698