Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1160783004: Revert of Re-land: Use script in depot_tools to retrieve builders from new cq.cfg (Closed)

Created:
5 years, 6 months ago by Peter Beverloo
Modified:
4 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-land: Use script in depot_tools to retrieve builders from new cq.cfg (patchset #2 id:20001 of https://codereview.chromium.org/1148303006/) Reason for revert: Breaks the "git cl try" command, see chromium-dev@ and crbug.com/495219. Traceback (most recent call last): File "/b/depot_tools/commit_queue.py", line 28, in <module> from cq_client import cq_pb2 File "/b/depot_tools/third_party/cq_client/cq_pb2.py", line 9, in <module> from google.protobuf import symbol_database as _symbol_database ImportError: cannot import name symbol_database BUG=495219 Original issue's description: > Re-land: Use script in depot_tools to retrieve builders from new cq.cfg > > TBR=akuegel@chromium.org, jochen@chromium.org > TEST=ran git-cl-try on this CL on Win, Mac and Linux > > Committed: https://crrev.com/2c7fb79b2aad9d924dcbcd663e09f3022884f502 > Cr-Commit-Position: refs/heads/master@{#332369} TBR=akuegel@chromium.org,jochen@chromium.org,sergiyb@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/cf0ee3bc5cb9f86398ca9c53a418e678b8ad952b Cr-Commit-Position: refs/heads/master@{#332384}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -26 lines) Patch
M PRESUBMIT.py View 1 chunk +25 lines, -26 lines 0 comments Download
A testing/commit_queue/OWNERS View 1 chunk +7 lines, -0 lines 0 comments Download
A testing/commit_queue/config.json View 1 chunk +102 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Peter Beverloo
Created Revert of Re-land: Use script in depot_tools to retrieve builders from new cq.cfg
5 years, 6 months ago (2015-06-02 14:36:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160783004/1
5 years, 6 months ago (2015-06-02 14:36:47 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-02 14:38:12 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cf0ee3bc5cb9f86398ca9c53a418e678b8ad952b Cr-Commit-Position: refs/heads/master@{#332384}
5 years, 6 months ago (2015-06-02 14:39:11 UTC) #4
Sergiy Byelozyorov
lgtm
4 years, 9 months ago (2016-03-23 15:15:49 UTC) #5
Sergiy Byelozyorov
4 years, 9 months ago (2016-03-23 15:18:18 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698