extensions: Check |enable_extensions| flag before depending on extension code.

extensions: Check |enable_extensions| flag before depending on extension code.

Avoid depending on (or including) extensions related code when enable_extensions
gyp/gn flag is not set. This fixes 'gn gen' for android with toolkit_views turned
on.

BUG=488576
Committed: https://crrev.com/46709b27b2caa9a4203eef168ac11291ec8d2834
Cr-Commit-Position: refs/heads/master@{#333690}

[sadrul, 2015-06-06 03:29:57]

sadrul@chromium.org changed reviewers:
+ benwells@chromium.org, sky@chromium.org

[sadrul, 2015-06-06 03:29:57]

benwells@chromium.org: Please review changes in apps/

sky@chromium.org: Please review changes in chrome/

[sky, 2015-06-06 17:53:37]

sky@chromium.org changed reviewers:
+ brettw@chromium.org
- sky@chromium.org

[sky, 2015-06-06 17:53:37]

I'm not familiar with set_sources_assignment_filter, so I'm passing to Brett.

Secondarily, I thought we preferred a use_ prefix vs enabled, eg use_extensions?

[sadrul, 2015-06-06 19:16:17]

On 2015/06/06 17:53:37, sky wrote:
> I'm not familiar with set_sources_assignment_filter, so I'm passing to Brett.
> 
> Secondarily, I thought we preferred a use_ prefix vs enabled, eg
use_extensions?

We currently enable use of both prefixes (*cough*): e.g. use_aura, use_x11,
use_ozone etc., vs. enable_extensions, enable_plugins, enable_webrtc etc.

[brettw, 2015-06-07 22:48:00]

https://codereview.chromium.org/1160773004/diff/1/chrome/browser/ui/BUILD.gn
File chrome/browser/ui/BUILD.gn (right):

https://codereview.chromium.org/1160773004/diff/1/chrome/browser/ui/BUILD.gn#...
chrome/browser/ui/BUILD.gn:211: sources_assignment_filter + [ "*/extensions/*"
])
Our rule in the GN build is to only use the filter for platform stuff, not
features.

Can you separate out the views extension sources into a separate variable and
conditionally include them?

[sadrul, 2015-06-09 21:08:35]

https://codereview.chromium.org/1160773004/diff/1/chrome/browser/ui/BUILD.gn
File chrome/browser/ui/BUILD.gn (right):

https://codereview.chromium.org/1160773004/diff/1/chrome/browser/ui/BUILD.gn#...
chrome/browser/ui/BUILD.gn:211: sources_assignment_filter + [ "*/extensions/*"
])
On 2015/06/07 22:48:00, brettw wrote:
> Our rule in the GN build is to only use the filter for platform stuff, not
> features.
> 
> Can you separate out the views extension sources into a separate variable and
> conditionally include them?

Done.

[brettw, 2015-06-09 21:38:48]

lgtm

[sadrul, 2015-06-10 03:44:14]

I am going to put this in the CQ. benwells@ if you have feedback, please let me
know, and I will address them (in a follow-up CL if this one lands before then).

[sadrul, 2015-06-10 03:44:18]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2015-06-10 03:44:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1160773004/20001

[commit-bot: I haz the power, 2015-06-10 03:51:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-10 03:51:12]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[benwells, 2015-06-10 04:20:33]

sorry, missed this. lgtm

[sadrul, 2015-06-10 05:09:52]

The CQ bit was checked by sadrul@chromium.org

[sadrul, 2015-06-10 05:09:52]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1160773004/#ps40001
(title: "tot-merge")

[commit-bot: I haz the power, 2015-06-10 05:09:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1160773004/40001

[commit-bot: I haz the power, 2015-06-10 06:09:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-10 06:10:47]

Patchset 3 (id:??) landed as
https://crrev.com/46709b27b2caa9a4203eef168ac11291ec8d2834
Cr-Commit-Position: refs/heads/master@{#333690}