Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: tools/gn/ninja_binary_target_writer.h

Issue 1160773002: Add support for module-definition files to gn (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove conditional compilation and add tests Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/BUILDCONFIG.gn ('k') | tools/gn/ninja_binary_target_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_binary_target_writer.h
diff --git a/tools/gn/ninja_binary_target_writer.h b/tools/gn/ninja_binary_target_writer.h
index 22d2332c8f409c9a5d852128bedb43fb76ef3d00..977e9823fe4fd075949b2f1d9058126cc66ac541 100644
--- a/tools/gn/ninja_binary_target_writer.h
+++ b/tools/gn/ninja_binary_target_writer.h
@@ -26,9 +26,11 @@ class NinjaBinaryTargetWriter : public NinjaTargetWriter {
typedef std::set<OutputFile> OutputFileSet;
void WriteCompilerVars();
- void WriteSources(std::vector<OutputFile>* object_files);
- void WriteLinkerStuff(const std::vector<OutputFile>& object_files);
- void WriteLinkerFlags();
+ void WriteSources(std::vector<OutputFile>* object_files,
+ std::vector<SourceFile>* other_files);
+ void WriteLinkerStuff(const std::vector<OutputFile>& object_files,
+ const std::vector<SourceFile>& other_files);
+ void WriteLinkerFlags(const SourceFile* optional_def_file);
void WriteLibs();
void WriteOutputExtension();
void WriteSolibs(const std::vector<OutputFile>& solibs);
« no previous file with comments | « build/config/BUILDCONFIG.gn ('k') | tools/gn/ninja_binary_target_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698