Don't cache reflection drawings

Source/platform/graphics/paint/DisplayItem.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "platform/graphics/paint/DisplayItem.h"
 
 namespace blink {
 
 struct SameSizeAsDisplayItem {
     virtual ~SameSizeAsDisplayItem() { } // Allocate vtable pointer.
     void* pointers[2];
-    int m_int; // Make sure m_int and m_type are next to each other so they are packed on 64-bit.
-    DisplayItem::Type m_type;
+    int ints[2]; // Make sure other fields are packed into two ints.

[chrishtr, 2015/06/02 20:40:18]

So DisplayItem has not gotten bigger due to this patch?

[Xianzhu, 2015/06/02 20:52:24]

Right.

 #ifndef NDEBUG
     WTF::String m_debugString;
 #endif
 };
 
 static_assert(sizeof(DisplayItem) == sizeof(SameSizeAsDisplayItem), "DisplayItem should stay small");
-static_assert(sizeof(DisplayItem::Type) <= sizeof(int), "DisplayItem::Type should stay small");
 
 #ifndef NDEBUG
 
 static WTF::String paintPhaseAsDebugString(int paintPhase)
 {
     // Must be kept in sync with PaintPhase.
     switch (paintPhase) {
     case 0: return "PaintPhaseBlockBackground";
     case 1: return "PaintPhaseChildBlockBackground";
     case 2: return "PaintPhaseChildBlockBackgrounds";
@@ skipping 175 matching lines @@
 void DisplayItem::dumpPropertiesAsDebugString(WTF::StringBuilder& stringBuilder) const
 {
     stringBuilder.append(String::format("client: \"%p", client()));
     if (!clientDebugString().isEmpty()) {
         stringBuilder.append(' ');
         stringBuilder.append(clientDebugString());
     }
     stringBuilder.append("\", type: \"");
     stringBuilder.append(typeAsDebugString(type()));
     stringBuilder.append('"');
-    if (m_id.scopeContainer)
-        stringBuilder.append(String::format(", scope: \"%p,%d\"", m_id.scopeContainer, m_id.scopeId));
+    if (m_skippedCache)
+        stringBuilder.append(", skippedCache: true");
+    if (m_scopeContainer)
+        stringBuilder.append(String::format(", scope: \"%p,%d\"", m_scopeContainer, m_scopeId));
 }
 
 #endif
 
 } // namespace blink