Issue 1160763004: Add support for testing content in SkyView

Issue 1160763004: Add support for testing content in SkyView (Closed)

Created:
5 years, 7 months ago by abarth-chromium

Modified:
5 years, 7 months ago

Reviewers:
eseidel

CC:
gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add support for testing content in SkyView R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ad88479106ac06ba7eb99548ed847fbb810a7b30

Patch Set 1 #

Total comments: 2

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+176 lines, -38 lines)			Patch
M	sky/engine/bindings/builtin_natives.cc	View	5 chunks	+15 lines, -8 lines	0 comments	Download
M	sky/engine/tonic/BUILD.gn	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sky/engine/tonic/dart_state.h	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	sky/engine/tonic/dart_state.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
A	sky/engine/tonic/dart_timer_heap.h	View	1 chunk	+44 lines, -0 lines	0 comments	Download
A	sky/engine/tonic/dart_timer_heap.cc	View	1 chunk	+56 lines, -0 lines	0 comments	Download
M	sky/sdk/lib/framework/layout2.dart	View	4 chunks	+8 lines, -9 lines	0 comments	Download
D	sky/tests/framework/basic.dart	View	1 chunk	+0 lines, -15 lines	0 comments	Download
M	sky/tests/framework/basic.sky	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A +	sky/tests/framework/resources/basic.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	sky/tests/raw/render_box.dart	View	1 chunk	+40 lines, -0 lines	0 comments	Download
A +	sky/tests/raw/render_box-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/tools/webkitpy/layout_tests/port/base.py	View	2 chunks	+2 lines, -2 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

eseidel

lgtm https://codereview.chromium.org/1160763004/diff/1/sky/tools/webkitpy/layout_tests/port/base.py File sky/tools/webkitpy/layout_tests/port/base.py (right): https://codereview.chromium.org/1160763004/diff/1/sky/tools/webkitpy/layout_tests/port/base.py#newcode233 sky/tools/webkitpy/layout_tests/port/base.py:233: '--content-handlers=text/sky,mojo:sky_viewer,text/plain,mojo:sky_viewer', Should .dart be served as text/plain?

5 years, 7 months ago (2015-05-27 19:37:08 UTC) #2

eseidel

https://github.com/domokit/mojo/blob/master/sky/tools/skygo/sky_server.go#L32

5 years, 7 months ago (2015-05-27 19:37:43 UTC) #3

abarth-chromium

https://codereview.chromium.org/1160763004/diff/1/sky/tools/webkitpy/layout_tests/port/base.py File sky/tools/webkitpy/layout_tests/port/base.py (right): https://codereview.chromium.org/1160763004/diff/1/sky/tools/webkitpy/layout_tests/port/base.py#newcode233 sky/tools/webkitpy/layout_tests/port/base.py:233: '--content-handlers=text/sky,mojo:sky_viewer,text/plain,mojo:sky_viewer', On 2015/05/27 at 19:37:08, eseidel wrote: > Should ...

5 years, 7 months ago (2015-05-27 20:13:50 UTC) #4

abarth-chromium

5 years, 7 months ago (2015-05-27 20:14:13 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ad88479106ac06ba7eb99548ed847fbb810a7b30 (presubmit successful).

Expand Messages | Collapse Messages