Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart

Issue 1160763002: dart2js cps: 'is'-check directly against type variables. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Rebase + status Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart
index 32c50efa80aa2997b8452e47fe2fbadf88d1b4fe..175abfcfb33d6c9e39756594cb2f081a3456a59a 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart
@@ -404,8 +404,15 @@ class InvokeConstructor extends Expression implements Invoke {
class TypeOperator extends Expression {
Reference<Primitive> value;
final DartType type;
- /// Type arguments to [type]. Since [type] may reference type variables in the
- /// enclosing class, these are not constant.
+
+ /// If [type] is a [GenericType], this holds the internal representation of
+ /// the type arguments to [type]. Since these may reference type variables
+ /// from the enclosing class, they are not constant.
+ ///
+ /// If [type] is a [TypeVariableType], this is a singleton list with
+ /// the internal representation of the type held in that type variable.
+ ///
+ /// Otherwise the list is empty.
final List<Reference<Primitive>> typeArguments;
final Reference<Continuation> continuation;
// TODO(johnniwinther): Use `Operator` class to encapsule the operator type.
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart ('k') | pkg/compiler/lib/src/js_backend/codegen/codegen.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698