Chromium Code Reviews Chromium Code Reviews
Issue 1160763002:
dart2js cps: 'is'-check directly against type variables. (Closed)
Base URL: git@github.com:dart-lang/sdk.git@master| Index: tests/language/language_dart2js.status |
| diff --git a/tests/language/language_dart2js.status b/tests/language/language_dart2js.status |
| index ad7367ee13369ec5c97e9e3846a40303f943dd96..cc25572c3fdeb56d4a07c76438e99c2326409ad8 100644 |
| --- a/tests/language/language_dart2js.status |
| +++ b/tests/language/language_dart2js.status |
| @@ -571,7 +571,6 @@ execute_finally6_test: Crash # try/finally |
| execute_finally7_test: Crash # try/finally |
| execute_finally8_test: Crash # (try {sum+= 1;return 'hi';}finally {sum+= 1;throw 'ball';sum+= 1;}): try/finally |
| execute_finally9_test: Crash # try/finally |
| -factory3_test: Crash # Instance of 'TypeOperator': type check unimplemented for T. |
| factory_redirection3_cyclic_test/01: Crash # Please triage this failure. |
| factory_redirection_test/01: Crash # Instance of 'TypeOperator': type check unimplemented for A<List>. |
| factory_redirection_test/04: Crash # Instance of 'TypeOperator': type check unimplemented for A<List>. |
| @@ -580,7 +579,6 @@ factory_redirection_test/06 : MissingRuntimeError |
| factory_return_type_checked_test: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary. |
| factory_type_parameter2_test: Crash # Please triage this failure. |
| factory_type_parameter_test: Crash # Instance of 'TypeOperator': type check unimplemented for A<List>. |
| -fast_method_extraction_test: Crash # Instance of 'TypeOperator': type check unimplemented for T. |
| final_super_field_set_test/01: RuntimeError # Please triage this failure. |
| finally_test: Crash # (try {i=12;}finally {Expect.equals(12,i);executedFinally=true;}): try/finally |
| first_class_types_literals_test/03: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary. |
| @@ -593,12 +591,6 @@ first_class_types_literals_test/09: Crash # Instance of 'TypeOperator': type che |
| first_class_types_literals_test/10: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary. |
| first_class_types_literals_test/11: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary. |
| first_class_types_literals_test/12: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary. |
| -fixed_type_variable2_test/01: Crash # Instance of 'TypeOperator': type check unimplemented for T. |
| -fixed_type_variable2_test/02: Crash # Instance of 'TypeOperator': type check unimplemented for T. |
| -fixed_type_variable2_test/03: Crash # Instance of 'TypeOperator': type check unimplemented for T. |
| -fixed_type_variable2_test/04: Crash # Instance of 'TypeOperator': type check unimplemented for T. |
| -fixed_type_variable2_test/05: Crash # Instance of 'TypeOperator': type check unimplemented for T. |
| -fixed_type_variable2_test/06: Crash # Instance of 'TypeOperator': type check unimplemented for T. |
| flatten_test/01: Crash # (test()async{int x=await new Derived<int>();}): cannot handle async/sync*/async* functions |
| flatten_test/02: Crash # (test()async{Future<int> f()async=>new Derived<int>();}): cannot handle async/sync*/async* functions |
| flatten_test/03: Crash # cannot handle async/sync*/async* functions |
| @@ -671,7 +663,6 @@ function_type_alias4_test: Crash # Instance of 'TypeOperator': type check unimpl |
| function_type_alias6_test/none: Crash # Instance of 'TypeOperator': type check unimplemented for F. |
| function_type_alias_test: Crash # Instance of 'TypeOperator': type check unimplemented for Fun. |
| function_type_call_getter_test: Crash # Instance of 'TypeOperator': type check unimplemented for F. |
| -generic2_test: Crash # Instance of 'TypeOperator': type check unimplemented for T. |
| generic_closure_test: Crash # Instance of 'TypeOperator': type check unimplemented for F. |
| generic_constructor_mixin2_test: Crash # Please triage this failure. |
| generic_constructor_mixin3_test: Crash # Please triage this failure. |
| @@ -680,12 +671,7 @@ generic_field_mixin2_test: Crash # Please triage this failure. |
| generic_field_mixin3_test: Crash # Instance of 'TypeOperator': type check unimplemented for A<T>. |
| generic_field_mixin_test: Crash # Instance of 'TypeOperator': type check unimplemented for A<int>. |
| generic_instanceof2_test: Crash # Instance of 'TypeOperator': type check unimplemented for Foo<int, num>. |
| -generic_instanceof4_test: Crash # Instance of 'TypeOperator': type check unimplemented for T. |
| -generic_instanceof5_test: Crash # Instance of 'TypeOperator': type check unimplemented for T. |
| -generic_instanceof_test: Crash # Instance of 'TypeOperator': type check unimplemented for List<T>. |
| generic_list_checked_test: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary. |
| -generic_native_test: Crash # Instance of 'TypeOperator': type check unimplemented for T. |
| -generic_object_type_test: Crash # Instance of 'TypeOperator': type check unimplemented for T. |
| generic_test: Crash # Instance of 'TypeOperator': type check unimplemented for B<AA>. |
| if_null_assignment_behavior_test/01: Crash # Please triage this failure. |
| if_null_assignment_behavior_test/02: Crash # Please triage this failure. |
| @@ -805,8 +791,7 @@ infinite_switch_label_test: Crash # Instance of 'TypeOperator': type check unimp |
| inlined_throw_test: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary. |
| instance_creation_in_function_annotation_test: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary. |
| instanceof3_test: Crash # Instance of 'TypeOperator': type check unimplemented for UndeclaredType. |
| -instanceof4_test/01: Crash # Instance of 'TypeOperator': type check unimplemented for List<T>. |
| -instanceof4_test/none: Crash # Instance of 'TypeOperator': type check unimplemented for List<T>. |
| +instanceof4_test/01 : RuntimeError |
|
karlklose
2015/05/28 07:42:30
Are the RuntimeError failures bugs in the runtime
asgerf
2015/05/28 08:52:55
It's because we don't set runtime type information
|
| integer_division_by_zero_test: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary. |
| interceptor6_test: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary. |
| interceptor_test: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary. |
| @@ -855,7 +840,6 @@ malformed_inheritance_test/09: Crash # Please triage this failure. |
| malformed_inheritance_test/10: Crash # Please triage this failure. |
| malformed_test/06: Crash # Please triage this failure. |
| malformed_test/none: Crash # Please triage this failure. |
| -many_generic_instanceof_test: Crash # Instance of 'TypeOperator': type check unimplemented for List<T>. |
| many_overridden_no_such_method_test: RuntimeError # Please triage this failure. |
| megamorphic_no_such_method_test: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary. |
| method_override4_test: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary. |
| @@ -884,7 +868,6 @@ mixin_issue10216_test: Crash # Instance of 'TypeOperator': type casts not implem |
| mixin_lib_extends_field_test: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary. |
| mixin_lib_extends_method_test: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary. |
| mixin_method_test: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary. |
| -mixin_only_for_rti_test: Crash # Instance of 'TypeOperator': type check unimplemented for T. |
| mixin_super_constructor2_test: Crash # Please triage this failure. |
| mixin_super_constructor_default_test: Crash # Please triage this failure. |
| mixin_super_constructor_multiple_test: Crash # Please triage this failure. |
| @@ -916,7 +899,6 @@ non_const_super_negative_test: Crash # Please triage this failure. |
| not_enough_positional_arguments_test/00: MissingRuntimeError # Please triage this failure. |
| not_enough_positional_arguments_test/03: Crash # Please triage this failure. |
| null_inline_test: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary. |
| -null_is2_test: Crash # Instance of 'TypeOperator': type check unimplemented for T. |
| null_no_such_method_test: Crash # Instance of 'TypeOperator': type check unimplemented for _Nullary. |
| null_test/01: Crash # Instance of 'TypeOperator': type check unimplemented for dynamic. |
| null_test/02: Crash # Instance of 'TypeOperator': type check unimplemented for dynamic. |
| @@ -1106,3 +1088,4 @@ issue10721_test : RuntimeError |
| mixin_mixin7_test : Pass |
| cast2_test/01 : Crash # Instance of 'TypeOperator': type casts not implemented. |
| cast2_test/none : Crash # Instance of 'TypeOperator': type casts not implemented. |
| +generic_field_mixin4_test : RuntimeError |
|
asgerf
2015/05/28 08:52:55
This is addressed by the other CL.
|
