LayoutTests/fast/events/uievent-with-inputdevice.html - Issue 1160753005: Implement UIEvent.sourceDevice

Side by Side Diff: LayoutTests/fast/events/uievent-with-inputdevice.html

Issue 1160753005: Implement UIEvent.sourceDevice (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add arugment name Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <head>

	2 <script src="../../resources/js-test.js"></script>

	3 </head>

	4 <body>

	5 <script>

	6 description("This tests that all the subclasses of UIEvent will have sourceD evice.firesTouchEvents set to be false by default, but it can also be passed whe n initialization.")

	7

	8 if (window.testRunner) {

	9 testRunner.dumpAsText();

	10 }

	11

	12 var firesTouchEvents = false;

	13 document.addEventListener("click", function(event) {

	14 firesTouchEvents = event.sourceDevice.firesTouchEvents;
	Rick Byers 2015/06/04 14:52:35 sourceDevice is actually supposed to be null here sourceDevice is actually supposed to be null here (by default, events created from script should not have a sourceDevice - although one can be provided explicitly in the EventInit dictionary). Maybe for this CL you could just make sourceDevice null for the script-generated events, and your dummy default value for some/all other generated events and then test that, for example, a 'click' event generated from script has null, but a 'click' event generated via eventSender.mousedown/mouseup has non-null sourceDevice and sourceDevice.firesTouchEvents false. tdresser 2015/06/04 15:34:24 Oops, thanks Rick. I caught that here(https://cod Show quoted text On 2015/06/04 14:52:35, Rick Byers wrote: > sourceDevice is actually supposed to be null here (by default, events created > from script should not have a sourceDevice - although one can be provided > explicitly in the EventInit dictionary). > > Maybe for this CL you could just make sourceDevice null for the script-generated > events, and your dummy default value for some/all other generated events and > then test that, for example, a 'click' event generated from script has null, but > a 'click' event generated via eventSender.mousedown/mouseup has non-null > sourceDevice and sourceDevice.firesTouchEvents false. Oops, thanks Rick. I caught that here(https://codereview.chromium.org/1161783006/diff/20001/LayoutTests/fast/events/touch/create-touch-event-source-device.html#newcode19) but I missed it in this patch. I'll take another look at this patch once this is fixed.
	15 });

	16

	17 var e = new MouseEvent('click');

	18

	19 document.dispatchEvent(e);

	20

	21 shouldBeFalse('firesTouchEvents');
	Rick Byers 2015/06/04 14:52:35 nit: move this shouldBe into the event handler its nit: move this shouldBe into the event handler itself. That way the test output will change if, for example, the handler gets invoked more than once for some reason.
	22

	23 if (window.internals) {

	24 internals.setFiresTouchEvents(e, true);
	Rick Byers 2015/06/04 14:52:35 I don't think this internals API is worth the cost I don't think this internals API is worth the cost - you're not really testing much here. Instead our test coverage of the different default values on InputDevice should come through event sender. I.e. once you've wired up mouse events to get a different InputDevice than TouchEvents, then we should use EventSender to generate mouse, touch and gesture events and verify that sourceDevice.firesTouchEvents is what we expect. For now I'd suggest removing this part of the test.
	25 }

	26 document.dispatchEvent(e);

	27

	28 shouldBeTrue('firesTouchEvents');

	29

	30 </script>

	31 </body>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/events/uievent-with-inputdevice-expected.txt » ('j') | Source/core/events/UIEvent.cpp » ('J')