Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 116073004: Fix MIPS switch statement breakage. (Closed)

Created:
7 years ago by Hannes Payer (out of office)
Modified:
7 years ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Fix MIPS switch statement breakage. BUG= Committed: https://code.google.com/p/v8/source/detail?r=18351

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M src/mips/full-codegen-mips.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Hannes Payer (out of office)
7 years ago (2013-12-18 15:09:35 UTC) #1
Toon Verwaest
https://codereview.chromium.org/116073004/diff/1/src/mips/full-codegen-mips.cc File src/mips/full-codegen-mips.cc (right): https://codereview.chromium.org/116073004/diff/1/src/mips/full-codegen-mips.cc#newcode1046 src/mips/full-codegen-mips.cc:1046: __ Branch(&next_test, ne, v0, Operand(zero_reg)); Probably should compare v0 ...
7 years ago (2013-12-18 15:14:15 UTC) #2
Hannes Payer (out of office)
https://codereview.chromium.org/116073004/diff/1/src/mips/full-codegen-mips.cc File src/mips/full-codegen-mips.cc (right): https://codereview.chromium.org/116073004/diff/1/src/mips/full-codegen-mips.cc#newcode1046 src/mips/full-codegen-mips.cc:1046: __ Branch(&next_test, ne, v0, Operand(zero_reg)); On 2013/12/18 15:14:16, Toon ...
7 years ago (2013-12-18 15:18:03 UTC) #3
Hannes Payer (out of office)
TBR
7 years ago (2013-12-18 15:31:14 UTC) #4
Hannes Payer (out of office)
7 years ago (2013-12-18 15:31:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r18351.

Powered by Google App Engine
This is Rietveld 408576698