PRESUBMIT #include check: exclude known cases which need a non-standard order.

PRESUBMIT #include check: exclude known cases which need a non-standard order.

BUG=NONE
NOTRY=true


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173773

[marja, 2012-12-18 13:29:15]

ptal

[M-A Ruel, 2012-12-18 13:37:33]

https://codereview.chromium.org/11607019/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/11607019/diff/1/PRESUBMIT.py#newcode599
PRESUBMIT.py:599: if uncheckable_includes_pattern.match(line):
Why not just skip the file instead of aborting?

[marja, 2012-12-18 14:57:39]

Thanks for comments!

https://codereview.chromium.org/11607019/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/11607019/diff/1/PRESUBMIT.py#newcode599
PRESUBMIT.py:599: if uncheckable_includes_pattern.match(line):
On 2012/12/18 13:37:33, Marc-Antoine Ruel wrote:
> Why not just skip the file instead of aborting?

I assume you meant "line" instead of "file"; such a special include often
affects a couple of includes on the nearby lines, so, I'd need to skip them too
or suppress the errors -> it's easier to just skip the file in total.

Or if you meant "file", then, this code is in _ChekcIncludeOrderInFile, so, it
will only skip that file.

[M-A Ruel, 2012-12-18 20:02:07]

https://codereview.chromium.org/11607019/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/11607019/diff/1/PRESUBMIT.py#newcode599
PRESUBMIT.py:599: if uncheckable_includes_pattern.match(line):
On 2012/12/18 14:57:40, marja wrote:
> On 2012/12/18 13:37:33, Marc-Antoine Ruel wrote:
> > Why not just skip the file instead of aborting?
> 
> I assume you meant "line" instead of "file"; such a special include often
> affects a couple of includes on the nearby lines, so, I'd need to skip them
too
> or suppress the errors -> it's easier to just skip the file in total.
> 
> Or if you meant "file", then, this code is in _ChekcIncludeOrderInFile, so, it
> will only skip that file.

Yes I meant line and not file. I don't mind.

lgtm

[commit-bot: I haz the power, 2012-12-18 20:06:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/marja@chromium.org/11607019/1

[commit-bot: I haz the power, 2012-12-18 20:17:17]

Change committed as 173773