fixes #202, check IndexExpression

lib/src/checker/checker.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dev_compiler.src.checker.checker;
 
 import 'package:analyzer/analyzer.dart';
 import 'package:analyzer/src/generated/ast.dart';
 import 'package:analyzer/src/generated/element.dart';
 import 'package:analyzer/src/generated/scanner.dart' show Token, TokenType;
@@ skipping 726 matching lines @@
           break;
         case TokenType.BANG_EQ:
           break;
         default:
           assert(false);
       }
     }
     node.visitChildren(this);
   }
 
+  @override
+  void visitIndexExpression(IndexExpression node) {
+    if (_rules.isDynamicTarget(node.target)) {
+      _recordDynamicInvoke(node);
+    } else {
+      var element = node.staticElement;
+      if (element is MethodElement) {
+        var type = element.type as FunctionType;
+        node.index = checkArgument(node.index, type.normalParameterTypes[0]);

[Leaf, 2015/06/02 23:59:11]

Analyzer should catch bad arity, but probably still worth being defensive
against having no parameter types.

[Jennifer Messerly, 2015/06/03 00:06:54]

hmmm, good catch. Guess I should fix visitBinaryExpr too

+      } else {
+        // TODO(vsm): Assert that the analyzer found an error here?
+      }
+    }
+    node.visitChildren(this);
+  }
+
   DartType getType(TypeName name) {
     return (name == null) ? _rules.provider.dynamicType : name.type;
   }
 
   Expression checkAssignment(Expression expr, DartType type) {
     if (expr is ParenthesizedExpression) {
       expr.expression = checkAssignment(expr.expression, type);
     } else {
       final staticInfo = _rules.checkAssignment(expr, type, _constantContext);
       _recordMessage(staticInfo);
@@ skipping 83 matching lines @@
   void _recordDynamicInvoke(AstNode node) {
     _reporter.log(new DynamicInvoke(_rules, node));
   }
 
   void _recordMessage(StaticInfo info) {
     if (info == null) return;
     if (info.level >= logger.Level.SEVERE) _failure = true;
     _reporter.log(info);
   }
 }