Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1160673003: fixes #202, check IndexExpression (Closed)

Created:
5 years, 6 months ago by Jennifer Messerly
Modified:
5 years, 6 months ago
Reviewers:
Leaf
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -12 lines) Patch
M lib/runtime/dart/_internal.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart/collection.js View 1 3 chunks +3 lines, -3 lines 0 comments Download
M lib/src/checker/checker.dart View 1 2 chunks +26 lines, -3 lines 0 comments Download
M test/checker/checker_test.dart View 5 chunks +21 lines, -1 line 0 comments Download
M test/dart_codegen/expect/_internal/list.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart_codegen/expect/collection/hash_map.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart_codegen/expect/collection/linked_hash_map.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart_codegen/expect/collection/splay_tree.dart View 1 chunk +1 line, -1 line 0 comments Download
M tool/sdk_expected_errors.txt View 4 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Jennifer Messerly
5 years, 6 months ago (2015-06-02 23:28:48 UTC) #2
Jennifer Messerly
https://codereview.chromium.org/1160673003/diff/1/lib/runtime/dart/collection.js File lib/runtime/dart/collection.js (right): https://codereview.chromium.org/1160673003/diff/1/lib/runtime/dart/collection.js#newcode1221 lib/runtime/dart/collection.js:1221: result.set(dart.as(k, K), dart.as(v, V)); pretty neat how these just ...
5 years, 6 months ago (2015-06-02 23:29:47 UTC) #3
Leaf
https://codereview.chromium.org/1160673003/diff/1/lib/src/checker/checker.dart File lib/src/checker/checker.dart (right): https://codereview.chromium.org/1160673003/diff/1/lib/src/checker/checker.dart#newcode755 lib/src/checker/checker.dart:755: node.index = checkArgument(node.index, type.normalParameterTypes[0]); Analyzer should catch bad arity, ...
5 years, 6 months ago (2015-06-02 23:59:11 UTC) #4
Leaf
lgtm otherwise.
5 years, 6 months ago (2015-06-03 00:00:38 UTC) #5
Jennifer Messerly
https://codereview.chromium.org/1160673003/diff/1/lib/src/checker/checker.dart File lib/src/checker/checker.dart (right): https://codereview.chromium.org/1160673003/diff/1/lib/src/checker/checker.dart#newcode755 lib/src/checker/checker.dart:755: node.index = checkArgument(node.index, type.normalParameterTypes[0]); On 2015/06/02 23:59:11, Leaf wrote: ...
5 years, 6 months ago (2015-06-03 00:06:54 UTC) #6
Jennifer Messerly
added a check to visitIndex and visitBinary ... it won't report an error (should be ...
5 years, 6 months ago (2015-06-03 00:10:35 UTC) #7
Jennifer Messerly
5 years, 6 months ago (2015-06-03 00:10:48 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
79791ee3bcc8877590841e54cc87739bdbc08884 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698