Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1160663007: Fix filename checks (Closed)

Created:
5 years, 7 months ago by sullivan
Modified:
5 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M patch.py View 1 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
sullivan
5 years, 7 months ago (2015-05-27 18:06:04 UTC) #2
M-A Ruel
https://codereview.chromium.org/1160663007/diff/1/patch.py File patch.py (right): https://codereview.chromium.org/1160663007/diff/1/patch.py#newcode57 patch.py:57: for i in ('/'): Remove the for loop here ...
5 years, 7 months ago (2015-05-27 18:09:17 UTC) #3
sullivan
https://codereview.chromium.org/1160663007/diff/1/patch.py File patch.py (right): https://codereview.chromium.org/1160663007/diff/1/patch.py#newcode57 patch.py:57: for i in ('/'): On 2015/05/27 18:09:17, M-A Ruel ...
5 years, 7 months ago (2015-05-27 18:20:12 UTC) #4
M-A Ruel
lgtm
5 years, 7 months ago (2015-05-27 18:20:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160663007/20001
5 years, 7 months ago (2015-05-27 18:24:11 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-27 18:26:48 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295430

Powered by Google App Engine
This is Rietveld 408576698