Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1160643004: Fix cull rect computation for SVG{Container,Image,Shape}Painter outlines (Closed)

Created:
5 years, 6 months ago by fs
Modified:
5 years, 6 months ago
Reviewers:
chrishtr, pdr.
CC:
blink-reviews, blink-reviews-paint_chromium.org, dshwang, slimming-paint-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix cull rect computation for SVG{Container,Image,Shape}Painter outlines TEST=svg/custom/transformed-outlines.svg (S.P. strict cull rect) BUG=495368 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196704

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M Source/core/paint/ObjectPainter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/paint/ObjectPainter.cpp View 1 chunk +12 lines, -0 lines 2 comments Download
M Source/core/paint/SVGContainerPainter.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/paint/SVGImagePainter.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/paint/SVGShapePainter.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
fs
https://codereview.chromium.org/1160643004/diff/1/Source/core/paint/ObjectPainter.cpp File Source/core/paint/ObjectPainter.cpp (right): https://codereview.chromium.org/1160643004/diff/1/Source/core/paint/ObjectPainter.cpp#newcode24 Source/core/paint/ObjectPainter.cpp:24: outlineOutset = style.outlineSize(); This pattern appears to pop up ...
5 years, 6 months ago (2015-06-08 16:30:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160643004/1
5 years, 6 months ago (2015-06-08 22:56:42 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 6 months ago (2015-06-08 22:56:45 UTC) #6
chrishtr
lgtm https://codereview.chromium.org/1160643004/diff/1/Source/core/paint/ObjectPainter.cpp File Source/core/paint/ObjectPainter.cpp (right): https://codereview.chromium.org/1160643004/diff/1/Source/core/paint/ObjectPainter.cpp#newcode24 Source/core/paint/ObjectPainter.cpp:24: outlineOutset = style.outlineSize(); On 2015/06/08 at 16:30:51, fs ...
5 years, 6 months ago (2015-06-08 22:59:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160643004/1
5 years, 6 months ago (2015-06-08 23:00:40 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 23:05:36 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196704

Powered by Google App Engine
This is Rietveld 408576698