Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1582)

Unified Diff: net/der/input.h

Issue 1160643002: Remove dangerous std::string constructor for der::Input (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove FromCString; use uint8_t array literals instead of string literals now Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/der/input.h
diff --git a/net/der/input.h b/net/der/input.h
index 6731b0c0600afd22f623141252b7e2b58d413061..f8eb467a482dc765788c720da9e4ec6b9102522d 100644
--- a/net/der/input.h
+++ b/net/der/input.h
@@ -49,9 +49,6 @@ class NET_EXPORT_PRIVATE Input {
// Creates an Input from the given |data| and |len|.
Input(const uint8_t* data, size_t len);
- // Creates an Input from the given string |s|.
- explicit Input(const std::string& s);
-
// Returns the length in bytes of an Input's data.
size_t Length() const { return len_; }

Powered by Google App Engine
This is Rietveld 408576698