Remove dangerous std::string constructor for der::Input

net/der/input_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/logging.h"
 #include "net/der/input.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace net {
 namespace der {
 namespace test {
 
 const uint8_t kInput[] = {'t', 'e', 's', 't'};
 
 TEST(InputTest, Equals) {
   Input test(kInput, arraysize(kInput));
   Input test2(kInput, arraysize(kInput));
   EXPECT_TRUE(test.Equals(test2));
 
-  std::string input_copy(reinterpret_cast<const char*>(kInput),
-                         arraysize(kInput));
+  uint8_t input_copy[arraysize(kInput)] = {0};
+  memcpy(input_copy, kInput, arraysize(kInput));
   Input test_copy(input_copy);
   EXPECT_TRUE(test.Equals(test_copy));
 
   Input test_truncated(kInput, arraysize(kInput) - 1);
   EXPECT_FALSE(test.Equals(test_truncated));
   EXPECT_FALSE(test_truncated.Equals(test));
 }
 
 TEST(InputTest, StaticArray) {
   Input input(kInput);
@@ skipping 46 matching lines @@
 
   // Reset the reader and check that we can read to a mark previously set.
   reader = ByteReader(input);
   Input marked_data;
   ASSERT_TRUE(reader.ReadToMark(mark, &marked_data));
 }
 
 TEST(ByteReaderTest, CantReadToWrongMark) {
   Input out;
   Input in1(kInput, arraysize(kInput));
-  Input in2("test");
+
+  const uint8_t in2_bytes[] = {'t', 'e', 's', 't'};
+  Input in2(in2_bytes);
   ByteReader reader1(in1);
   ByteReader reader2(in2);
   ASSERT_TRUE(reader1.ReadBytes(2, &out));
   ASSERT_TRUE(reader2.ReadBytes(2, &out));
   Mark mark1 = reader1.NewMark();
   Mark mark2 = reader2.NewMark();
   reader1 = ByteReader(in1);
   reader2 = ByteReader(in2);
 
   // It is not possible to advance to a mark outside the underlying input.
@@ skipping 40 matching lines @@
   reader1 = ByteReader(in1);
   reader2 = ByteReader(in2);
 
   ASSERT_FALSE(reader1.AdvanceToMark(mark2));
   ASSERT_FALSE(reader2.AdvanceToMark(mark1));
 }
 
 }  // namespace test
 }  // namespace der
 }  // namespace net