Remove dangerous std::string constructor for der::Input

net/der/input.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_DER_INPUT_H_
 #define NET_DER_INPUT_H_
 
 #include <stdint.h>
 #include <string>
 
@@ skipping 28 matching lines @@
 class NET_EXPORT_PRIVATE Input {
  public:
   // Creates an empty Input, one from which no data can be read.
   Input();
 
   // Creates an Input from a constant array |data|.
   template <size_t N>
   explicit Input(const uint8_t(&data)[N])
       : data_(data), len_(N) {}
 
+  // Creates an Input from a null-terminated constant char array |data|. This is
+  // provided as a factory method instead of a constructor to avoid confusion
+  // with the similar constructor above which takes an array of uint8_t which is
+  // not null terminated.
+  template <size_t N>
+  static Input FromCString(const char(&data)[N]) {
+    return Input(reinterpret_cast<const uint8_t*>(data), N - 1);
+  }

[Ryan Sleevi, 2015/05/26 18:53:30]

Strictly on a STYLE basis, this shouldn't be interleaved between constructors.

However, from this CL, it doesn't seem that this is actually needed?

+
   // Creates an Input from the given |data| and |len|.
   Input(const uint8_t* data, size_t len);
 
-  // Creates an Input from the given string |s|.
-  explicit Input(const std::string& s);
-
   // Returns the length in bytes of an Input's data.
   size_t Length() const { return len_; }
 
   // Return true if the Input's data and |other|'s data are byte-wise equal.
   bool Equals(const Input& other) const;
 
   // Returns a pointer to the Input's data. This method is marked as "unsafe"
   // because access to the Input's data should be done through ByteReader
   // instead. This method should only be used where using a ByteReader truly
   // is not an option.
@@ skipping 86 matching lines @@
   explicit Mark(const uint8_t* ptr);
   Mark();
   const uint8_t* ptr_;
 };
 
 }  // namespace der
 
 }  // namespace net
 
 #endif  // NET_DER_INPUT_H_