Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Issue 1160633002: real fix for textblob use after gpu free (Closed)

Created:
5 years, 7 months ago by joshua.litt
Modified:
5 years, 7 months ago
Reviewers:
joshualitt, bsalomon, ericrk
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

real fix for textblob use after gpu free This patch addresses two issues: 1) Textblobs with abandoned strikes were not properly regenerating. 2) Provided by ericrk - GrTextBlobCache removed blobs from |fCache| during freeAll, but left potentially released blobs in the |fBlobList|. We now remove these from |fBlobList| as well. BUG=skia: Committed: https://skia.googlesource.com/skia/+/7a9c45c01cadea5d8b3e9671a57311247a8c414d

Patch Set 1 #

Patch Set 2 : tweaks #

Patch Set 3 : tweak #

Patch Set 4 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -5 lines) Patch
A gm/textblobuseaftergpufree.cpp View 1 2 3 1 chunk +73 lines, -0 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrCommandBuilder.cpp View 1 1 chunk +1 line, -3 lines 0 comments Download
M src/gpu/GrTextBlobCache.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
joshualitt
Eric, can you try this patch?
5 years, 7 months ago (2015-05-26 14:40:20 UTC) #2
ericrk
On 2015/05/26 14:40:20, joshualitt wrote: > Eric, can you try this patch? LGTM - this ...
5 years, 7 months ago (2015-05-26 18:00:27 UTC) #3
joshualitt
On 2015/05/26 18:00:27, ericrk wrote: > On 2015/05/26 14:40:20, joshualitt wrote: > > Eric, can ...
5 years, 7 months ago (2015-05-26 18:02:39 UTC) #4
bsalomon
lgtm
5 years, 7 months ago (2015-05-26 18:35:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160633002/40001
5 years, 7 months ago (2015-05-26 19:05:29 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/1078)
5 years, 7 months ago (2015-05-26 19:06:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160633002/60001
5 years, 7 months ago (2015-05-26 19:19:36 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-26 19:32:29 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/7a9c45c01cadea5d8b3e9671a57311247a8c414d

Powered by Google App Engine
This is Rietveld 408576698