Issue 116063003: Fix leak in MetricsLogTest.InitialLogStabilityMetrics test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 116063003: Fix leak in MetricsLogTest.InitialLogStabilityMetrics test. (Closed)

Created:
7 years ago by Alexei Svitkine (slow)

Modified:
7 years ago

Reviewers:
Ilya Sherman, earthdok

CC:
chromium-reviews, jar (doing other things), Ilya Sherman, asvitkine+watch_chromium.org, timurrrr+watch_chromium.org, glider+watch_chromium.org, bruening+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix leak in MetricsLogTest.InitialLogStabilityMetrics test. MetricsLog posts a task to the blocking pool, via MetricsNetworkObserver::ProbeWifiPHYLayerProtocol() which wasn't being cleaned up. Use TestBrowserThreadBundle instead of the deprecated TestBrowserThread to ensure all posted tasks are cleaned up. Also, removes suppressions for this leak. BUG=328987 TBR=isherman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241429

Patch Set 1 : #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -21 lines)			Patch
M	chrome/browser/metrics/metrics_service_unittest.cc	View	4 chunks	+3 lines, -6 lines	0 comments	Download
M	tools/lsan/suppressions.txt	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	tools/valgrind/memcheck/suppressions.txt	View	1 chunk	+0 lines, -11 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/116063003/40001

7 years ago (2013-12-17 20:35:38 UTC) #4

Message was sent while issue was closed.

Change committed as 241429

Expand Messages | Collapse Messages