cc: Unify context losing machinery

cc/gl_renderer.cc

Index: cc/gl_renderer.cc
diff --git a/cc/gl_renderer.cc b/cc/gl_renderer.cc
index bb4ec4d3ee99d55d33be2886d435eee999f986cd..e1900a9d5d7cd8d3e84a5feafd6cdf1b15f2c004 100644
--- a/cc/gl_renderer.cc
+++ b/cc/gl_renderer.cc
@@ -1510,7 +1510,8 @@ bool GLRenderer::bindFramebufferToTexture(DrawingFrame& frame, const ScopedResou
     unsigned textureId = m_currentFramebufferLock->textureId();
     GLC(m_context, m_context->framebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, textureId, 0));
 
-    DCHECK(m_context->checkFramebufferStatus(GL_FRAMEBUFFER) == GL_FRAMEBUFFER_COMPLETE);
+    if (m_context->checkFramebufferStatus(GL_FRAMEBUFFER) != GL_FRAMEBUFFER_COMPLETE)

[jamesr, 2012/12/18 05:40:11]

this is a sync call and pretty expensive in some drivers.  we definitely cannot
afford to make this call in production builds

[danakj, 2012/12/18 06:06:57]

Then we should probably just remove this line. The dcheck fires if you lose the
context, which isn't a "bug" in here.

[danakj, 2012/12/18 21:26:59]

Done.

+        return false;
 
     initializeMatrices(frame, framebufferRect, false);
     setDrawViewportSize(framebufferRect.size());