Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(907)

Side by Side Diff: content/browser/browser_plugin/browser_plugin_embedder.h

Issue 11606005: Browser Plugin: Simplify BrowserPluginGuestHelper (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge with ToT Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | content/browser/browser_plugin/browser_plugin_embedder.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // A BrowserPluginEmbedder has a list of guests it manages. 5 // A BrowserPluginEmbedder has a list of guests it manages.
6 // In the beginning when a renderer sees one or more guests (BrowserPlugin 6 // In the beginning when a renderer sees one or more guests (BrowserPlugin
7 // instance(s)) and there is a request to navigate to them, the WebContents for 7 // instance(s)) and there is a request to navigate to them, the WebContents for
8 // that renderer creates a BrowserPluginEmbedder for itself. The 8 // that renderer creates a BrowserPluginEmbedder for itself. The
9 // BrowserPluginEmbedder, in turn, manages a set of BrowserPluginGuests -- one 9 // BrowserPluginEmbedder, in turn, manages a set of BrowserPluginGuests -- one
10 // BrowserPluginGuest for each guest in the embedding WebContents. Note that 10 // BrowserPluginGuest for each guest in the embedding WebContents. Note that
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 95
96 // NotificationObserver method override. 96 // NotificationObserver method override.
97 virtual void Observe(int type, 97 virtual void Observe(int type,
98 const NotificationSource& source, 98 const NotificationSource& source,
99 const NotificationDetails& details) OVERRIDE; 99 const NotificationDetails& details) OVERRIDE;
100 100
101 // Message handlers (direct/indirect via BrowserPluginEmbedderHelper). 101 // Message handlers (direct/indirect via BrowserPluginEmbedderHelper).
102 // Routes update rect ack message to the appropriate guest. 102 // Routes update rect ack message to the appropriate guest.
103 void UpdateRectACK( 103 void UpdateRectACK(
104 int instance_id, 104 int instance_id,
105 int message_id,
106 const BrowserPluginHostMsg_AutoSize_Params& auto_size_params, 105 const BrowserPluginHostMsg_AutoSize_Params& auto_size_params,
107 const BrowserPluginHostMsg_ResizeGuest_Params& resize_guest_params); 106 const BrowserPluginHostMsg_ResizeGuest_Params& resize_guest_params);
108 void SetFocus(int instance_id, bool focused); 107 void SetFocus(int instance_id, bool focused);
109 // Handles input events sent from the BrowserPlugin (embedder's renderer 108 // Handles input events sent from the BrowserPlugin (embedder's renderer
110 // process) by passing them to appropriate guest's input handler. The 109 // process) by passing them to appropriate guest's input handler. The
111 // BrowserPlugin behaves like a black hole for events, so the embedder does 110 // BrowserPlugin behaves like a black hole for events, so the embedder does
112 // not see them in the capture or bubble phase. 111 // not see them in the capture or bubble phase.
113 // Currently scroll events do not propagate back to the embedder process 112 // Currently scroll events do not propagate back to the embedder process
114 // and so even if the guest discards a scroll event, it won't make its 113 // and so even if the guest discards a scroll event, it won't make its
115 // way back to the embedder. This may change in the future. 114 // way back to the embedder. This may change in the future.
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
186 GetRenderViewHostCallbackMap pending_get_render_view_callbacks_; 185 GetRenderViewHostCallbackMap pending_get_render_view_callbacks_;
187 // Next request id for BrowserPluginMsg_PluginAtPositionRequest query. 186 // Next request id for BrowserPluginMsg_PluginAtPositionRequest query.
188 int next_get_render_view_request_id_; 187 int next_get_render_view_request_id_;
189 188
190 DISALLOW_COPY_AND_ASSIGN(BrowserPluginEmbedder); 189 DISALLOW_COPY_AND_ASSIGN(BrowserPluginEmbedder);
191 }; 190 };
192 191
193 } // namespace content 192 } // namespace content
194 193
195 #endif // CONTENT_BROWSER_BROWSER_PLUGIN_BROWSER_PLUGIN_EMBEDDER_H_ 194 #endif // CONTENT_BROWSER_BROWSER_PLUGIN_BROWSER_PLUGIN_EMBEDDER_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/browser_plugin/browser_plugin_embedder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698