Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1160533002: Change outputting ints in win/linux GetCpuUsage to doubles. (Closed)

Created:
5 years, 7 months ago by rkaplow
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, erikwright+watch_chromium.org, Alexei Svitkine (slow)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change outputting ints in win/linux GetCpuUsage to doubles. Note the line I use in win is the same as currently in mac. I looked into refactoring the methods to use a common strategy but there isn't that much reuse since there are a lot of differences - the only common part is the conversion to percent which is a one-liner, so I left it. BUG=490879 Committed: https://crrev.com/4fb9a2c47c9412f135d43b00b792171acb26d14c Cr-Commit-Position: refs/heads/master@{#331369}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M base/process/process_metrics_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process/process_metrics_win.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rkaplow
5 years, 7 months ago (2015-05-25 15:23:48 UTC) #2
Lei Zhang
lgtm
5 years, 7 months ago (2015-05-25 19:41:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160533002/1
5 years, 7 months ago (2015-05-26 14:23:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-26 16:05:08 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-26 16:06:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4fb9a2c47c9412f135d43b00b792171acb26d14c
Cr-Commit-Position: refs/heads/master@{#331369}

Powered by Google App Engine
This is Rietveld 408576698