More infobar cleanup.

More infobar cleanup.

This was supposed to land in https://codereview.chromium.org/1142153002/ but I forgot to commit and upload the last change set :(

This removes two fields no one uses anymore from the navigation details struct.  It also eliminates some using statements from infobar_service.cc and inlines a helper into its now-lone caller.

BUG=none

Committed: https://crrev.com/c04096fa429f9b1189a09f59c476b6b7b0696c69
Cr-Commit-Position: refs/heads/master@{#333028}

[Peter Kasting, 2015-06-05 02:52:46]

pkasting@chromium.org changed reviewers:
+ isherman@chromium.org

[Peter Kasting, 2015-06-05 03:02:39]

pkasting@chromium.org changed reviewers:
+ droger@chromium.org

[Peter Kasting, 2015-06-05 03:02:40]

droger: ios
isherman: rest

https://codereview.chromium.org/1160443010/diff/20001/ios/chrome/browser/info...
File ios/chrome/browser/infobars/infobar_manager_impl.cc (right):

https://codereview.chromium.org/1160443010/diff/20001/ios/chrome/browser/info...
ios/chrome/browser/infobars/infobar_manager_impl.cc:24:
infobars::InfoBarDelegate::NavigationDetails navigation_details;
I reordered the code here so as to match the similar code in infobar_service.cc
as closely as possible.

[Ilya Sherman, 2015-06-05 03:20:47]

LGTM

[droger, 2015-06-05 07:40:48]

lgtm

[Peter Kasting, 2015-06-05 10:29:28]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2015-06-05 10:29:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1160443010/20001

[commit-bot: I haz the power, 2015-06-05 10:32:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-05 10:33:59]

Patchset 2 (id:??) landed as
https://crrev.com/c04096fa429f9b1189a09f59c476b6b7b0696c69
Cr-Commit-Position: refs/heads/master@{#333028}