Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 1160443003: Update Media Router WebUI JSDocs. (Closed)

Created:
5 years, 7 months ago by apacible
Modified:
5 years, 6 months ago
Reviewers:
mark a. foltz
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Media Router WebUI JSDocs. - Use @return instead of @return in media-router-container. - Move function comments into JSDoc @return in issue-banner. Committed: https://crrev.com/a719b2b6e63d2bc558db5392934de984fcd91e8c Cr-Commit-Position: refs/heads/master@{#331922}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M chrome/browser/resources/media_router/elements/issue_banner/issue_banner.js View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js View 1 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
apacible
PTAL, thanks!
5 years, 7 months ago (2015-05-27 23:31:52 UTC) #2
mark a. foltz
lgtm
5 years, 6 months ago (2015-05-28 23:43:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160443003/1
5 years, 6 months ago (2015-05-29 00:53:26 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/70854)
5 years, 6 months ago (2015-05-29 01:56:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160443003/20001
5 years, 6 months ago (2015-05-29 02:57:58 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-05-29 04:05:00 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-05-29 04:05:56 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a719b2b6e63d2bc558db5392934de984fcd91e8c
Cr-Commit-Position: refs/heads/master@{#331922}

Powered by Google App Engine
This is Rietveld 408576698