Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 1160433006: Notify InputMethodBase on TextInputState change to send InputMethodObserver::OnTextInputStateChange… (Closed)

Created:
5 years, 6 months ago by Shu Chen
Modified:
5 years, 6 months ago
Reviewers:
CC:
chromium-reviews, nona+watch_chromium.org, James Su, shuchen+watch_chromium.org, penghuang+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Notify InputMethodBase on TextInputState change to send InputMethodObserver::OnTextInputStateChanged notification InputMethodAuraLinux, which is derived from InputMethodBase, has implmented OnTextInputTypeChanged. And InputMethodAuraLinux is not propagating OntextInputTyepChanged to InputMethodBase, because of which InputMethodObserver's does not get the notification OnTextInputStateChanged. The cl is to propagate the change event to InputMethodBase so that InputMethodObserver APIs are notified appropriately. TBR=yukawa@chromium.org BUG=None TEST=None Committed: https://crrev.com/a44d2d01e6b6e77f60988cf166971cb79668346e Cr-Commit-Position: refs/heads/master@{#333008}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/base/ime/input_method_auralinux.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160433006/1
5 years, 6 months ago (2015-06-05 03:29:55 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-05 04:04:15 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 04:05:04 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a44d2d01e6b6e77f60988cf166971cb79668346e
Cr-Commit-Position: refs/heads/master@{#333008}

Powered by Google App Engine
This is Rietveld 408576698