Add a snapshot for docgen and use it in the build

sdk/bin/docgen

Index: sdk/bin/docgen
diff --git a/sdk/bin/dartdoc b/sdk/bin/docgen
similarity index 58%
copy from sdk/bin/dartdoc
copy to sdk/bin/docgen
index 45ba5125b3ad43f0a18139b0febcf246050a05e1..610cb4dff6d8e720dac0f71ada3904d2311e40e1 100755
--- a/sdk/bin/dartdoc
+++ b/sdk/bin/docgen
@@ -1,5 +1,5 @@
 #!/bin/bash
-# Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
+# Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
@@ -18,15 +18,6 @@ PROG_NAME="$(follow_links "$BASH_SOURCE")"
 # Handle the case where dart-sdk/bin has been symlinked to.
 BIN_DIR="$(cd "${PROG_NAME%/*}" ; pwd -P)"
 
-unset COLORS
-if test -t 1; then
-  # Stdout is a terminal.
-  if test 8 -le `tput colors`; then
-    # Stdout has at least 8 colors, so enable colors.
-    COLORS="--enable-diagnostic-colors"
-  fi
-fi
-
 unset SNAPSHOT
 
 SNAPSHOT="$BIN_DIR/snapshots/utils_wrapper.dart.snapshot"
@@ -34,11 +25,10 @@ SNAPSHOT="$BIN_DIR/snapshots/utils_wrapper.dart.snapshot"
 if test -f $SNAPSHOT; then
   # TODO(ahe): Remove the following line when we are relatively sure it works.
   echo Using snapshot $SNAPSHOT 1>&2
-  exec "$BIN_DIR"/dart --heap_growth_rate=32 \
-      "--package-root=$BIN_DIR/../packages/" $SNAPSHOT dartdoc $COLORS \
-      "--package-root=$BIN_DIR/../packages/" "--library-root=$BIN_DIR/.." "$@"
+  exec "$BIN_DIR"/dart --heap_growth_rate=32 --old_gen_heap_size=1024 \

[ricow1, 2014/01/08 06:39:49]

is this increased old gen size needed? (it is not an issue if it is, but if not
just leave it out). Also, does specialcasing the growth rate have a performance
impact on dartdoc, if not don't do it

[Alan Knight, 2014/01/08 22:19:02]

The heap size used to be needed or it wouldn't run at all. The growth rate was
in there from dartdoc and I just left it in. In practice neither appears to make
any difference to performance so I've removed them.

+      "--package-root=$BIN_DIR/../packages/" $SNAPSHOT docgen "$@"
 else
-  exec "$BIN_DIR"/dart --heap_growth_rate=32 \
+  exec "$BIN_DIR"/dart --heap_growth_rate=32 --old_gen_heap_size=1024 \
       "--package-root=$BIN_DIR/../packages/" \
-      "$BIN_DIR/../lib/_internal/dartdoc/bin/dartdoc.dart" $COLORS "$@"
+      "$BIN_DIR/../pkg/docgen/bin/docgen.dart" "$@"
 fi

[kustermann, 2014/01/08 08:39:18]

I really don't like the fact that we make more and more copies of these shell
scripts.

Why can't we at least share common routines in a sdk/bin/_common.sh file and
source that here? [or some other mechanism]

[Alan Knight, 2014/01/08 22:19:02]

This one should at least be script-neutral in that we would expect to delete the
dartdoc scripts once the new viewer is fully deployed. Created
https://code.google.com/p/dart/issues/detail?id=15973 for the general issue.