Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(981)

Unified Diff: utils/compiler/create_snapshot.dart

Issue 116043013: Add a snapshot for docgen and use it in the build (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Everything except the strictly snapshot-related pulled out to a different CL Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« utils/compiler/compiler.gyp ('K') | « utils/compiler/compiler.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/compiler/create_snapshot.dart
diff --git a/utils/compiler/create_snapshot.dart b/utils/compiler/create_snapshot.dart
index b7bb18b74109a98bec9402391673c5163e2ef722..f5f3b95519e5c6e40e15730c97313d3b4b2eca82 100644
--- a/utils/compiler/create_snapshot.dart
+++ b/utils/compiler/create_snapshot.dart
@@ -19,11 +19,13 @@ Future<String> getVersion(var rootPath) {
Future<String> getSnapshotGenerationFile(var args, var rootPath) {
var dart2js = rootPath.resolve(args["dart2js_main"]);
var dartdoc = rootPath.resolve(args["dartdoc_main"]);
+ var docgen = rootPath.resolve(args["docgen_main"]);
return getVersion(rootPath).then((version) {
var snapshotGenerationText =
"""
import '${dart2js.toFilePath(windows: false)}' as dart2jsMain;
import '${dartdoc.toFilePath(windows: false)}' as dartdocMain;
ricow1 2014/01/21 00:52:16 remove dartdoc
+import '${docgen.toFilePath(windows: false)}' as docgenMain;
import 'dart:io';
void main(List<String> arguments) {
@@ -34,6 +36,8 @@ void main(List<String> arguments) {
dart2jsMain.main(arguments.skip(1).toList());
} else if (tool == "dartdoc") {
ricow1 2014/01/21 00:52:16 remove
dartdocMain.main(arguments.skip(1).toList());
+ } else if (tool == "docgen") {
+ docgenMain.main(arguments.skip(1).toList());
}
}
@@ -72,6 +76,9 @@ Future createSnapshot(var dart_file, var packageRoot) {
dart_file])
.then((result) {
if (result.exitCode != 0) {
+ print("Could not generate snapshot: result code ${result.exitCode}");
+ print(result.stdout);
+ print(result.stderr);
throw "Could not generate snapshot";
}
});
@@ -80,11 +87,14 @@ Future createSnapshot(var dart_file, var packageRoot) {
/**
* Takes the following arguments:
* --output_dir=val The full path to the output_dir.
- * --dart2js_main=val The path to the dart2js main script releative to root.
+ * --dart2js_main=val The path to the dart2js main script relative to root.
+ * --dartdoc_main=val The path to the dartdoc main script relative to root.
ricow1 2014/01/21 00:52:16 remove
+ * --docgen_main=val The path to the docgen main script relative to root.
+ * --package-root=val The package-root used to find packages for the snapshot.
*/
void main(List<String> arguments) {
var validArguments = ["--output_dir", "--dart2js_main", "--dartdoc_main",
ricow1 2014/01/21 00:52:16 remove dartdoc
- "--package_root"];
+ "--docgen_main", "--package_root"];
var args = {};
for (var argument in arguments) {
var argumentSplit = argument.split("=");
@@ -96,6 +106,7 @@ void main(List<String> arguments) {
}
if (!args.containsKey("dart2js_main")) throw "Please specify dart2js_main";
if (!args.containsKey("dartdoc_main")) throw "Please specify dartdoc_main";
ricow1 2014/01/21 00:52:16 remove
+ if (!args.containsKey("docgen_main")) throw "Please specify docgen_main";
if (!args.containsKey("output_dir")) throw "Please specify output_dir";
if (!args.containsKey("package_root")) throw "Please specify package_root";
« utils/compiler/compiler.gyp ('K') | « utils/compiler/compiler.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698