ppapi/native_client/src/untrusted/pnacl_irt_shim/shim_ppapi.c - Issue 116043012: Put __pnacl_real_irt_interface variable in bss instead of common.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/native_client/src/untrusted/pnacl_irt_shim/shim_ppapi.c

Issue 116043012: Put __pnacl_real_irt_interface variable in bss instead of common. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/native_client/src/untrusted/pnacl_irt_shim/shim_ppapi.c

diff --git a/ppapi/native_client/src/untrusted/pnacl_irt_shim/shim_ppapi.c b/ppapi/native_client/src/untrusted/pnacl_irt_shim/shim_ppapi.c

index 70f17b244caaa98305231e6da9733c1b95d1b409..2fde01522c23516ebb88bf16d20aba800bc3ab4e 100644

--- a/ppapi/native_client/src/untrusted/pnacl_irt_shim/shim_ppapi.c

+++ b/ppapi/native_client/src/untrusted/pnacl_irt_shim/shim_ppapi.c

@@ -90,7 +90,7 @@ static int is_irt_interface_whitelisted(const char *interface_name) {

return 0;

}

-TYPE_nacl_irt_query __pnacl_real_irt_interface;

+TYPE_nacl_irt_query __pnacl_real_irt_interface = 0;

Mark Seaborn 2014/01/07 22:22:59 BTW, this should be NULL rather than 0.

jvoung (off chromium) 2014/01/07 23:59:00 Done.

* These remember the interface pointers the user registers by calling the

« no previous file with comments | « no previous file | no next file » | no next file with comments »