Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 116043010: Fix JNI generation dependency in android_webview_unittests. (Closed)

Created:
6 years, 11 months ago by Primiano Tucci (use gerrit)
Modified:
6 years, 11 months ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

Fix JNI generation dependency in android_webview_unittests. In the current gyp rules, the unittests depend on the following three children: (1) java, (2) native and (3) jni generation. This is not correct as (2) has a functional dependency on (2). Having (3) being a sibling of (2), as it is now, introduces a race when building the unittest target from clean. This change fixes the problem making the jni generation step a dependency of the native build, rather than a sibling. BUG=None TEST=ninja -C out/Debug android_webview_unittests_apk NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243426

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M android_webview/android_webview_tests.gypi View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Primiano Tucci (use gerrit)
PTAL I tested locally building from clean and seems to work reliably after the change.
6 years, 11 months ago (2014-01-06 18:51:25 UTC) #1
Torne
lgtm
6 years, 11 months ago (2014-01-07 12:35:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/116043010/1
6 years, 11 months ago (2014-01-07 18:09:41 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242633
6 years, 11 months ago (2014-01-07 22:06:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/116043010/1
6 years, 11 months ago (2014-01-07 23:09:44 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 23:16:55 UTC) #6
Message was sent while issue was closed.
Change committed as 243426

Powered by Google App Engine
This is Rietveld 408576698