Source/modules/app_banner/BeforeInstallPromptEvent.idl - Issue 1160413004: Add hooks for BeforeInstallPromptEvent to be redispatched.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/app_banner/BeforeInstallPromptEvent.idl

Issue 1160413004: Add hooks for BeforeInstallPromptEvent to be redispatched. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Returning Promise<void> and tidying implementation Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/app_banner/BeforeInstallPromptEvent.cpp ('k') | public/platform/modules/app_banner/WebAppBannerClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/app_banner/BeforeInstallPromptEvent.idl

diff --git a/Source/modules/app_banner/BeforeInstallPromptEvent.idl b/Source/modules/app_banner/BeforeInstallPromptEvent.idl

index 30f2a7f5415f1a80e4ec99dd60b422a7b8b1748e..d9cfb85c81ab6be617aeef8eaa2160dd1337d1f3 100644

--- a/Source/modules/app_banner/BeforeInstallPromptEvent.idl

+++ b/Source/modules/app_banner/BeforeInstallPromptEvent.idl

@@ -8,4 +8,6 @@

] interface BeforeInstallPromptEvent : Event {

readonly attribute sequence<DOMString> platforms;

[CallWith=ScriptState] readonly attribute Promise<DOMString> userChoice;

mlamouri (slow - plz ping) 2015/06/17 16:27:37 nit: no new line

dominickn (DO NOT USE) 2015/06/17 17:50:40 Done.

+ [CallWith=ScriptState] Promise<void> prompt();

};

« no previous file with comments | « Source/modules/app_banner/BeforeInstallPromptEvent.cpp ('k') | public/platform/modules/app_banner/WebAppBannerClient.h » ('j') | no next file with comments »