Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2015 The Chromium Authors. All rights reserved. | 1 // Copyright 2015 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #ifndef WebAppBannerClient_h | 5 #ifndef WebAppBannerClient_h |
| 6 #define WebAppBannerClient_h | 6 #define WebAppBannerClient_h |
| 7 | 7 |
| 8 #include "public/platform/WebCallbacks.h" | 8 #include "public/platform/WebCallbacks.h" |
| 9 #include "public/platform/modules/app_banner/WebAppBannerPromptResult.h" | 9 #include "public/platform/modules/app_banner/WebAppBannerPromptResult.h" |
| 10 | 10 |
| 11 namespace blink { | 11 namespace blink { |
| 12 | 12 |
| 13 using WebAppBannerCallbacks = WebCallbacks<WebAppBannerPromptResult, void>; | 13 using WebAppBannerCallbacks = WebCallbacks<WebAppBannerPromptResult, void>; |
| 14 | 14 |
| 15 class WebAppBannerClient { | 15 class WebAppBannerClient { |
| 16 public: | 16 public: |
| 17 virtual ~WebAppBannerClient() { } | 17 virtual ~WebAppBannerClient() { } |
| 18 | 18 |
| 19 // Ownership of the callbacks is transferred to the client. | 19 // Ownership of the callbacks is transferred to the client. |
| 20 virtual void registerBannerCallbacks(int requestId, WebAppBannerCallbacks*) = 0; | 20 virtual void registerBannerCallbacks(int requestId, WebAppBannerCallbacks*) = 0; |
| 21 | |
| 22 // Tell the client that the event is to be redispatched. | |
| 23 // | |
| 24 // TODO(dominickn) This method should be pure virtual. However, making it | |
| 25 // pure virtual causes compilation failures in tests. This is because the | |
| 26 // tests instantiate an AppBannerClient, which lives in the Chromium | |
| 27 // repository and inherits from this class. Once AppBannerClient has been | |
| 28 // updated to override this method, it will be made pure virtual. For now, | |
| 29 // it has a dummy do-nothing implementation. | |
|
mlamouri (slow - plz ping)
2015/06/06 21:40:55
nit: remove the comment. Not having the function p
| |
| 30 virtual void resolveEventRedispatch(int requestId) { } | |
| 21 }; | 31 }; |
| 22 | 32 |
| 23 } // namespace blink | 33 } // namespace blink |
| 24 | 34 |
| 25 #endif // WebAppBannerClient_h | 35 #endif // WebAppBannerClient_h |
| OLD | NEW |