Source/modules/app_banner/BeforeInstallPromptEvent.idl - Issue 1160413004: Add hooks for BeforeInstallPromptEvent to be redispatched.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/app_banner/BeforeInstallPromptEvent.idl

Issue 1160413004: Add hooks for BeforeInstallPromptEvent to be redispatched. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/modules/app_banner/BeforeInstallPromptEvent.cpp ('K') | « Source/modules/app_banner/BeforeInstallPromptEvent.cpp ('k') | public/platform/modules/app_banner/WebAppBannerClient.h » ('j') | public/platform/modules/app_banner/WebAppBannerClient.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 [	5 [

6 Constructor(DOMString type, optional BeforeInstallPromptEventInit eventInitD ict),	6 Constructor(DOMString type, optional BeforeInstallPromptEventInit eventInitD ict),

7 RuntimeEnabled=AppBanner,	7 RuntimeEnabled=AppBanner,

8 ] interface BeforeInstallPromptEvent : Event {	8 ] interface BeforeInstallPromptEvent : Event {

9 readonly attribute sequence<DOMString> platforms;	9 readonly attribute sequence<DOMString> platforms;

10 [CallWith=ScriptState] readonly attribute Promise<DOMString> userChoice;	10 [CallWith=ScriptState] readonly attribute Promise<DOMString> userChoice;

	11

	12 void prompt();
	mlamouri (slow - plz ping) 2015/06/06 21:40:55 The tests are failing because of this addition. It The tests are failing because of this addition. It changes the exposed interfaces to the Web which is checked by the following tests to prevent unexpected changes: webexposed/global-interface-listing.html virtual/stable/webexposed/global-interface-listing.html Note that virtual/stable/ tests the interface for a stable release while the first test tests for a "test" version. That also means that in order to land this change you will need to send an Intent to Implement and Ship in blink-dev and get it approved. Otherwise, you should send an "Intent to Implement", have the prompt() method implemented behind a flag and send an "Intent to Ship" when the method is ready to ship. More information can be found here: http://www.chromium.org/blink#TOC-Web-Platform-Changes:-Process
11 };	13 };

OLD	NEW