Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1160403005: ios: Remove use of MessageLoopProxy and deprecated MessageLoop APIs (Closed)

Created:
5 years, 6 months ago by Sami
Modified:
5 years, 6 months ago
Reviewers:
stuartmorgan
CC:
chromium-reviews, erikwright (departed), cbentzel+watch_chromium.org, Jackie Quinn
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ios: Remove use of MessageLoopProxy and deprecated MessageLoop APIs BUG=465354 Committed: https://crrev.com/9c8e5d7259661cda32b698ee88254491e6984900 Cr-Commit-Position: refs/heads/master@{#333080} Committed: https://crrev.com/c2740989a381adccbd243574a4ddc97423ca8808 Cr-Commit-Position: refs/heads/master@{#333105}

Patch Set 1 #

Patch Set 2 : Build fixes. #

Patch Set 3 : Build fix. #

Patch Set 4 : Fix build error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -66 lines) Patch
M ios/chrome/browser/net/retryable_url_fetcher_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/snapshots/snapshot_cache.mm View 3 chunks +8 lines, -10 lines 0 comments Download
M ios/crnet/crnet_environment.mm View 1 6 chunks +12 lines, -14 lines 0 comments Download
M ios/net/cookies/cookie_store_ios.mm View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/public/web_thread.h View 1 4 chunks +10 lines, -12 lines 0 comments Download
M ios/web/shell/shell_browser_state.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/web/shell/shell_url_request_context_getter.h View 3 chunks +2 lines, -3 lines 0 comments Download
M ios/web/shell/shell_url_request_context_getter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_thread_adapter.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_thread_impl.cc View 1 5 chunks +17 lines, -18 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Sami
5 years, 6 months ago (2015-06-05 16:15:55 UTC) #2
stuartmorgan
LGTM +jyquinn as an FYI since this may impact merge (although it may not, since ...
5 years, 6 months ago (2015-06-05 17:08:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160403005/40001
5 years, 6 months ago (2015-06-05 17:09:30 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-05 17:13:20 UTC) #6
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/9c8e5d7259661cda32b698ee88254491e6984900 Cr-Commit-Position: refs/heads/master@{#333080}
5 years, 6 months ago (2015-06-05 17:14:16 UTC) #7
Nicolas Zea
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1167533009/ by zea@chromium.org. ...
5 years, 6 months ago (2015-06-05 17:31:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160403005/60001
5 years, 6 months ago (2015-06-05 18:55:25 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 6 months ago (2015-06-05 19:15:40 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 19:24:15 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c2740989a381adccbd243574a4ddc97423ca8808
Cr-Commit-Position: refs/heads/master@{#333105}

Powered by Google App Engine
This is Rietveld 408576698