Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Issue 1160373004: Move safe_strerror to posix directory and the base namespace (Closed)

Created:
5 years, 6 months ago by brettw
Modified:
5 years, 6 months ago
Reviewers:
danakj
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, toyoshim+midi_chromium.org, tfarina, lcwu+watch_chromium.org, gavinp+memory_chromium.org, feature-media-reviews_chromium.org, yfriedman+watch_chromium.org, gunsch+watch_chromium.org, klundberg+watch_chromium.org, erikwright+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move safe_strerror to posix directory and the base namespace. Since this is a wrapper around a posix thing that doesn't fall under any other categories, the posix directory is probably the best place. Committed: https://crrev.com/6ee6fd6efabf8b87324d0b233ea2332c4a0e1642 Cr-Commit-Position: refs/heads/master@{#333524}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -199 lines) Patch
M base/BUILD.gn View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M base/base.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M base/debug/debugger_posix.cc View 1 chunk +0 lines, -1 line 0 comments Download
M base/logging.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/memory/shared_memory_posix.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + base/posix/safe_strerror.h View 2 chunks +7 lines, -3 lines 0 comments Download
A + base/posix/safe_strerror.cc View 1 2 chunks +7 lines, -2 lines 0 comments Download
D base/safe_strerror_posix.h View 1 chunk +0 lines, -38 lines 0 comments Download
D base/safe_strerror_posix.cc View 1 chunk +0 lines, -119 lines 0 comments Download
M base/threading/platform_thread_posix.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/process_singleton_posix.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/certificate_manager_handler.cc View 1 2 5 chunks +9 lines, -5 lines 0 comments Download
M chromecast/base/process_utils.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M media/midi/midi_manager_alsa.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M tools/android/forwarder2/command.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M tools/android/forwarder2/common.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/android/forwarder2/daemon.cc View 1 chunk +0 lines, -1 line 0 comments Download
M tools/android/forwarder2/host_forwarder_main.cc View 1 chunk +0 lines, -1 line 0 comments Download
M tools/android/forwarder2/pipe_notifier.cc View 1 chunk +0 lines, -1 line 0 comments Download
M tools/android/forwarder2/socket.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M tools/gn/bootstrap/bootstrap.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160373004/1
5 years, 6 months ago (2015-06-04 21:01:37 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/78771) ios_dbg_simulator_ninja on ...
5 years, 6 months ago (2015-06-04 21:21:13 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160373004/20001
5 years, 6 months ago (2015-06-04 21:24:51 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/78168) android_chromium_gn_compile_rel on ...
5 years, 6 months ago (2015-06-04 21:39:15 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160373004/40001
5 years, 6 months ago (2015-06-05 16:45:57 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-05 17:51:33 UTC) #13
brettw
Whoops, forgot to actually send mail.
5 years, 6 months ago (2015-06-09 16:53:17 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160373004/60001
5 years, 6 months ago (2015-06-09 16:54:19 UTC) #16
danakj
LGTM
5 years, 6 months ago (2015-06-09 17:23:04 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160373004/60001
5 years, 6 months ago (2015-06-09 17:26:21 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 6 months ago (2015-06-09 18:05:36 UTC) #21
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 18:06:26 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6ee6fd6efabf8b87324d0b233ea2332c4a0e1642
Cr-Commit-Position: refs/heads/master@{#333524}

Powered by Google App Engine
This is Rietveld 408576698