Issue 1160343003: Revert "fixes #173, ability to use native JS indexers"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1160343003: Revert "fixes #173, ability to use native JS indexers" (Closed)

Created:
5 years, 6 months ago by Jennifer Messerly

Modified:
5 years, 6 months ago

Reviewers:
vsm

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "fixes #173, ability to use native JS indexers" This reverts commit 8dc1eeeb4dcc4d186f59513abd18f98e67c36339. Committed: https://github.com/dart-lang/dev_compiler/commit/0d4abcd1558e48d2106542ddb4432f3267a7a4f0

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -96 lines)			Patch
M	lib/src/codegen/js_codegen.dart	View	7 chunks	+6 lines, -23 lines	0 comments	Download
M	lib/src/utils.dart	View	2 chunks	+1 line, -14 lines	0 comments	Download
D	test/codegen/domtest.dart	View	1 chunk	+0 lines, -16 lines	0 comments	Download
D	test/codegen/expect/domtest.js	View	1 chunk	+0 lines, -16 lines	0 comments	Download
D	test/codegen/expect/domtest.txt	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	test/codegen/expect/sunflower/dom.js	View	2 chunks	+2 lines, -5 lines	0 comments	Download
M	test/codegen/sunflower/dom.dart	View	2 chunks	+0 lines, -21 lines	0 comments	Download

Total messages: 3 (1 generated)

Jennifer Messerly

Committed patchset #1 (id:1) manually as 0d4abcd1558e48d2106542ddb4432f3267a7a4f0 (presubmit successful).

5 years, 6 months ago (2015-06-01 16:31:06 UTC) #1

Jennifer Messerly

5 years, 6 months ago (2015-06-01 16:31:36 UTC) #3

Message was sent while issue was closed.

TBR, this is a full git revert of https://codereview.chromium.org/1145833004