Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1160323004: [DevTools] Move emulated devices to separate module. (Closed)

Created:
4 years, 11 months ago by dgozman
Modified:
4 years, 10 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Move emulated devices to separate module. BUG=315607 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196781

Patch Set 1 #

Patch Set 2 : Fixed compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+649 lines, -59 lines) Patch
M Source/devtools/BUILD.gn View 1 3 chunks +3 lines, -0 lines 0 comments Download
M Source/devtools/devtools.gyp View 1 2 chunks +2 lines, -0 lines 0 comments Download
M Source/devtools/devtools.gypi View 1 3 chunks +4 lines, -0 lines 0 comments Download
A Source/devtools/front_end/emulated_devices/module.json View 1 chunk +604 lines, -0 lines 0 comments Download
M Source/devtools/front_end/emulation/EmulatedDevices.js View 4 chunks +35 lines, -21 lines 0 comments Download
M Source/devtools/front_end/emulation/OverridesUI.js View 1 chunk +0 lines, -36 lines 0 comments Download
M Source/devtools/front_end/inspector.json View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/scripts/concatenate_application_code.py View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
dgozman
Take a look please.
4 years, 11 months ago (2015-06-05 14:13:56 UTC) #2
pfeldman
lgtm
4 years, 10 months ago (2015-06-08 17:52:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160323004/1
4 years, 10 months ago (2015-06-08 17:54:04 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/46813)
4 years, 10 months ago (2015-06-08 18:01:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160323004/20001
4 years, 10 months ago (2015-06-09 15:31:00 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2015-06-09 16:39:30 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196781

Powered by Google App Engine
This is Rietveld 408576698