Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1695)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1160293005: Removing unused functions from FileChooser class (Closed)

Created:
5 years, 6 months ago by shiva.jm
Modified:
5 years, 6 months ago
Reviewers:
Habib Virji, pdr., Mike West
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Removing unused functions from FileChooser class This patch removes the following unused functions: FileChooser::chooseFile() BUG=439559 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196666

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M Source/platform/FileChooser.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/FileChooser.cpp View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
shiva.jm
pls have a look.
5 years, 6 months ago (2015-06-08 08:42:31 UTC) #2
Mike West
LGTM, assuming Chromium compiles. :)
5 years, 6 months ago (2015-06-08 08:57:05 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160293005/1
5 years, 6 months ago (2015-06-08 09:46:33 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/46773)
5 years, 6 months ago (2015-06-08 09:55:51 UTC) #7
shiva.jm
On 2015/06/08 08:57:05, Mike West wrote: > LGTM, assuming Chromium compiles. :) I think mac ...
5 years, 6 months ago (2015-06-08 10:09:41 UTC) #8
shiva.jm
pls have a look, reverted the Theme class apis.
5 years, 6 months ago (2015-06-08 10:26:38 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160293005/20001
5 years, 6 months ago (2015-06-08 10:26:58 UTC) #12
Mike West
On 2015/06/08 at 10:26:58, commit-bot wrote: > Dry run: CQ is trying da patch. Follow ...
5 years, 6 months ago (2015-06-08 10:41:03 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-08 11:21:49 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160293005/20001
5 years, 6 months ago (2015-06-08 11:23:05 UTC) #17
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 11:26:47 UTC) #18
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196666

Powered by Google App Engine
This is Rietveld 408576698