Add tests for Android GL driver version extraction.

gpu/config/gpu_info_collector_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/scoped_ptr.h"
 #include "gpu/config/gpu_info.h"
 #include "gpu/config/gpu_info_collector.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/gl/gl_implementation.h"
@@ skipping 133 matching lines @@
   EXPECT_EQ(test_values_.pixel_shader_version,
             gpu_info.pixel_shader_version);
   EXPECT_EQ(test_values_.vertex_shader_version,
             gpu_info.vertex_shader_version);
   EXPECT_EQ(test_values_.gl_version, gpu_info.gl_version);
   EXPECT_EQ(test_values_.gl_renderer, gpu_info.gl_renderer);
   EXPECT_EQ(test_values_.gl_vendor, gpu_info.gl_vendor);
   EXPECT_EQ(test_values_.gl_extensions, gpu_info.gl_extensions);
 }
 
+class CollectDriverInfoGLTest : public testing::Test {
+ public:
+  CollectDriverInfoGLTest() {}
+  ~CollectDriverInfoGLTest() override {}
+
+  void SetUp() override {
+  }
+  void TearDown() override {
+  }
+};
+
+TEST_F(CollectDriverInfoGLTest, CollectDriverInfoGL) {
+  const struct {
+    const char* gl_renderer;
+    const char* gl_vendor;
+    const char* gl_version;
+    const char* expected_driver_version;
+  } tests[] = {

[no sievers, 2015/06/03 20:28:13]

nit: s/tests/kTestStrings or so

+#if defined(OS_ANDROID)

[no sievers, 2015/06/03 20:28:13]

nit: I'd ifdef out the whole test thingie and put a comment that only on Android
we attempt to get the driver version from the GL_VERSION string.

+    {"Adreno (TM) 320", "Qualcomm", "OpenGL ES 2.0 V@14.0 AU@04.02 (CL@3206)",
+     "14.0"},
+    {"Adreno (TM) 420", "Qualcomm", "OpenGL ES 3.0 V@84.0 AU@ (CL@)", "84.0"},
+    {"PowerVR Rogue G6430", "Imagination Technologies",
+     "OpenGL ES 3.1 build 1.4@3283119", "1.4"},
+    {"Mali-T604", "ARM", "OpenGL ES 3.1", "0"},
+    {"NVIDIA Tegra", "NVIDIA Corporation", "OpenGL ES 3.1 NVIDIA 343.00",
+     "343.00"},

[no sievers, 2015/06/03 20:28:14]

Can you also update the comment in gpu_info_collector_android.cc since it
doesn't apply anymore?

  // Extract driver version from the second number in a string like:
  // "OpenGL ES 2.0 V@6.0 AU@ (CL@2946718)"

Maybe just say that it tries to find a version number behind the 'OpenGL ES x.x'
string?

+    {"NVIDIA Tegra 3", "NVIDIA Corporation", "OpenGL ES 2.0 14.01003",
+     "14.01003"},
+#endif
+    {NULL, NULL, NULL, NULL}
+ };
+
+  GPUInfo gpu_info;
+  for (int i = 0; tests[i].gl_renderer != NULL; ++i) {
+    gpu_info.gl_renderer = tests[i].gl_renderer;
+    gpu_info.gl_vendor = tests[i].gl_vendor;
+    gpu_info.gl_version = tests[i].gl_version;
+    EXPECT_EQ(CollectDriverInfoGL(&gpu_info), kCollectInfoSuccess);
+    EXPECT_EQ(gpu_info.driver_version, tests[i].expected_driver_version);
+  }
+}
+
 }  // namespace gpu