Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: samples/pdfium_test.cc

Issue 1160293003: Fix windows compile: fix size_t vs. int mismatch (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: samples/pdfium_test.cc
diff --git a/samples/pdfium_test.cc b/samples/pdfium_test.cc
index d5bf3c0f16993189dba1487fae1c99d43026eb34..407d81fdbe9b8f4c3e7c011da5ff24c645c5b5c2 100644
--- a/samples/pdfium_test.cc
+++ b/samples/pdfium_test.cc
@@ -582,9 +582,10 @@ int main(int argc, const char* argv[]) {
v8::Platform* platform = v8::platform::CreateDefaultPlatform();
v8::V8::InitializePlatform(platform);
v8::V8::Initialize();
+
// By enabling predicatble mode, V8 won't post any background tasks.
Lei Zhang 2015/06/02 22:17:05 typo, btw
- const char predictable_flag[] = "--predictable";
- v8::V8::SetFlagsFromString(predictable_flag, strlen(predictable_flag));
+ static const char predictable_flag[] = "--predictable";
+ v8::V8::SetFlagsFromString(predictable_flag, sizeof(predictable_flag) - 1);
Lei Zhang 2015/06/02 22:17:05 Sigh, why are they taking an int for a string leng
#ifdef V8_USE_EXTERNAL_STARTUP_DATA
v8::StartupData natives;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698